-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Notes update for 2021.4 #272
Conversation
Signed-off-by: Valentina Kats valentina.kats@intel.com
Signed-off-by: Valentina Kats valentina.kats@intel.com
documentation/release_notes.rst
Outdated
- Added the range-based versions of the following algorithms: ``any_of``, ``adjacent_find``, | ||
``copy_if``, ``remove_copy_if``, ``remove_copy``, ``none_of``, ``swap_ranges``, ``unique``, ``unique_copy``, | ||
``reverse``, ``reverse_copy``, ``rotate_copy``, ``replace_copy``, ``replace_copy_if``. | ||
- Added non-blocking versions of the following algorithms: ``inclusive_scan``, ``exclusive_scan``, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be "asynchronous versions"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"non-blocking versions" terminology was used in 2021.2.0 release notes. To change to "asynchronous versions" or to keep consistent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a slight favor for non-blocking to describe the behavior as an attribute. How about changing the description to asynchronous algorithm? But we should make the change consistent to the change log.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reble changes were added. Feel free to review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok from my side. All the comments I would write are there
Signed-off-by: Valentina Kats valentina.kats@intel.com
Signed-off-by: Valentina Kats valentina.kats@intel.com
Signed-off-by: Valentina Kats valentina.kats@intel.com
Singed-off-by: Valentina Kats valentina.kats@intel.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two suggestions below are not blocking yet would be great to make. But in case of time pressure, feel free to commit as is.
Signed-off-by: Valentina Kats valentina.kats@intel.com
* Update release_notes.rst Signed-off-by: Valentina Kats valentina.kats@intel.com * Update release_notes.rst Signed-off-by: Valentina Kats valentina.kats@intel.com * Address review feedback Signed-off-by: Valentina Kats valentina.kats@intel.com * Add new known issue about ``-fopenm-simd`` option Signed-off-by: Valentina Kats valentina.kats@intel.com * Remove note about internal hetero patterns rework Signed-off-by: Valentina Kats valentina.kats@intel.com * Address review feedback Singed-off-by: Valentina Kats valentina.kats@intel.com * Address review feedback Signed-off-by: Valentina Kats valentina.kats@intel.com
* Update release_notes.rst Signed-off-by: Valentina Kats valentina.kats@intel.com * Update release_notes.rst Signed-off-by: Valentina Kats valentina.kats@intel.com * Address review feedback Signed-off-by: Valentina Kats valentina.kats@intel.com * Add new known issue about ``-fopenm-simd`` option Signed-off-by: Valentina Kats valentina.kats@intel.com * Remove note about internal hetero patterns rework Signed-off-by: Valentina Kats valentina.kats@intel.com * Address review feedback Singed-off-by: Valentina Kats valentina.kats@intel.com * Address review feedback Signed-off-by: Valentina Kats valentina.kats@intel.com
* Update release_notes.rst Signed-off-by: Valentina Kats valentina.kats@intel.com * Update release_notes.rst Signed-off-by: Valentina Kats valentina.kats@intel.com * Address review feedback Signed-off-by: Valentina Kats valentina.kats@intel.com * Add new known issue about ``-fopenm-simd`` option Signed-off-by: Valentina Kats valentina.kats@intel.com * Remove note about internal hetero patterns rework Signed-off-by: Valentina Kats valentina.kats@intel.com * Address review feedback Singed-off-by: Valentina Kats valentina.kats@intel.com * Address review feedback Signed-off-by: Valentina Kats valentina.kats@intel.com
Signed-off-by: Valentina Kats valentina.kats@intel.com