Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unnamed lambda compilation issue #306

Merged
merged 4 commits into from
Aug 10, 2021

Conversation

rarutyun
Copy link
Contributor

No description provided.

@rarutyun rarutyun force-pushed the rarutyun/unnamed_labmda_compilation_fix branch 3 times, most recently from 4428525 to d064948 Compare August 3, 2021 00:45
@rarutyun rarutyun changed the title Fix unnamed lambda comipation issue Fix unnamed lambda compilation issue Aug 3, 2021
@rarutyun rarutyun force-pushed the rarutyun/unnamed_labmda_compilation_fix branch 6 times, most recently from f4f87fc to 56d391b Compare August 6, 2021 12:04
@rarutyun rarutyun force-pushed the rarutyun/unnamed_labmda_compilation_fix branch 2 times, most recently from 48ba5fa to 77a3462 Compare August 9, 2021 16:04
@rarutyun rarutyun force-pushed the rarutyun/unnamed_labmda_compilation_fix branch 4 times, most recently from 5ee55eb to a96bdc0 Compare August 9, 2021 18:40
@rarutyun rarutyun force-pushed the rarutyun/unnamed_labmda_compilation_fix branch from a96bdc0 to e2dc5be Compare August 10, 2021 13:26
@rarutyun rarutyun force-pushed the rarutyun/unnamed_labmda_compilation_fix branch from e2dc5be to 0e19d5a Compare August 10, 2021 13:33
Copy link
Contributor

@MikeDvorskiy MikeDvorskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no questions any more

Copy link
Contributor

@dmitriy-sobolev dmitriy-sobolev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Feel free to apply or not apply suggestion for naming of KernelName_t and __kernel_name_provider.

@rarutyun
Copy link
Contributor Author

We have some connectivity issues with RHEL step. I was able to see that all tests for parallel algorithms were passed before losing the connection. I don't see the showstoppers for that patch to land. I will make sure that everything is ok after connectivity issue is resolved.

@rarutyun rarutyun merged commit 9bb4626 into main Aug 10, 2021
@rarutyun rarutyun deleted the rarutyun/unnamed_labmda_compilation_fix branch August 10, 2021 16:28
@rarutyun
Copy link
Contributor Author

RHEL step successfully passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants