Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KT] Support for descending sort order #956

Merged
merged 5 commits into from
May 22, 2023
Merged

[KT] Support for descending sort order #956

merged 5 commits into from
May 22, 2023

Conversation

akukanov
Copy link
Contributor

No implementation changes appear necessary, except for onesweep to use the order as designed.

In the test, I enable the possibility to test everything in descending order, off by default. It's similar to other template parameters - WG size, etc. We will need to find out how to test for different parameter values without сombinatorial explosion.

SergeyKopienko
SergeyKopienko approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@SergeyKopienko SergeyKopienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SergeyKopienko
Copy link
Contributor

SergeyKopienko commented May 22, 2023 •
edited
Loading

About "We will need to find out how to test for different parameter values without сombinatorial explosion."
This approach already implemented in the TestUtils namespace but for another entities. For example please take a look at test/support/utils_invoke.h

@akukanov akukanov merged commit 6afb04e into dev/dmitriy-sobolev/esimd-radix-sort May 22, 2023
@akukanov akukanov deleted the dev/kt-check-sort-order-akukanov branch May 22, 2023 11:48
SergeyKopienko pushed a commit that referenced this pull request May 24, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
0e13f63
dmitriy-sobolev pushed a commit that referenced this pull request May 29, 2023
@akukanov @dmitriy-sobolev
[KT] Support for descending sort order (#956)
d2a1b6d
SergeyKopienko pushed a commit that referenced this pull request May 31, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
2c8761a
SergeyKopienko pushed a commit that referenced this pull request Jun 1, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
b2d15a6
SergeyKopienko pushed a commit that referenced this pull request Jun 2, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
6a4bb51
SergeyKopienko pushed a commit that referenced this pull request Jun 2, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
798ad61
SergeyKopienko pushed a commit that referenced this pull request Jun 7, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
c022640
SergeyKopienko pushed a commit that referenced this pull request Jun 9, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
d600891
SergeyKopienko pushed a commit that referenced this pull request Jun 20, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
accd9c1
SergeyKopienko pushed a commit that referenced this pull request Jun 26, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
2a14a01
SergeyKopienko pushed a commit that referenced this pull request Jun 26, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
1c44527
SergeyKopienko pushed a commit that referenced this pull request Jun 28, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
6ea8e5f
SergeyKopienko pushed a commit that referenced this pull request Jun 29, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
ead762e
dmitriy-sobolev pushed a commit that referenced this pull request Jul 11, 2023
@akukanov @dmitriy-sobolev
[KT] Support for descending sort order (#956)
aa332de
SergeyKopienko pushed a commit that referenced this pull request Jul 17, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
9fca98b
SergeyKopienko pushed a commit that referenced this pull request Jul 28, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
74ae472
SergeyKopienko pushed a commit that referenced this pull request Jul 28, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
38e98ee
SergeyKopienko pushed a commit that referenced this pull request Jul 31, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
ec08fbf
SergeyKopienko pushed a commit that referenced this pull request Jul 31, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
0d3f58d
SergeyKopienko pushed a commit that referenced this pull request Sep 13, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
fb32f23
SergeyKopienko pushed a commit that referenced this pull request Sep 14, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
869658c
SergeyKopienko pushed a commit that referenced this pull request Sep 14, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
3214573
SergeyKopienko pushed a commit that referenced this pull request Sep 14, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
edac94a
SergeyKopienko pushed a commit that referenced this pull request Sep 19, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
ceb4d27
SergeyKopienko pushed a commit that referenced this pull request Sep 19, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
15e595e
SergeyKopienko pushed a commit that referenced this pull request Sep 22, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
3d6fcbb
SergeyKopienko pushed a commit that referenced this pull request Sep 29, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
4b7940c
SergeyKopienko pushed a commit that referenced this pull request Oct 4, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
5d52dae
SergeyKopienko pushed a commit that referenced this pull request Oct 5, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
314e0c9
SergeyKopienko pushed a commit that referenced this pull request Oct 6, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
3f42eb3
SergeyKopienko pushed a commit that referenced this pull request Oct 9, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
12ffd38
SergeyKopienko pushed a commit that referenced this pull request Oct 12, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
595d408
SergeyKopienko pushed a commit that referenced this pull request Oct 12, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
f4e61b0
SergeyKopienko pushed a commit that referenced this pull request Oct 16, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
b2af5ac
SergeyKopienko pushed a commit that referenced this pull request Oct 18, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
05f0e10
SergeyKopienko pushed a commit that referenced this pull request Oct 19, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
a7897f1
SergeyKopienko pushed a commit that referenced this pull request Oct 23, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
d7a9a7f
SergeyKopienko pushed a commit that referenced this pull request Oct 24, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
6260ba6
SergeyKopienko pushed a commit that referenced this pull request Oct 25, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
5a5b162
dmitriy-sobolev pushed a commit that referenced this pull request Oct 31, 2023
@akukanov @dmitriy-sobolev
[KT] Support for descending sort order (#956)
ece8213
dmitriy-sobolev pushed a commit that referenced this pull request Nov 1, 2023
@akukanov @dmitriy-sobolev
[KT] Support for descending sort order (#956)
47a91b7
SergeyKopienko pushed a commit that referenced this pull request Nov 3, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
d145f91
dmitriy-sobolev pushed a commit that referenced this pull request Nov 8, 2023
@akukanov @dmitriy-sobolev
[KT] Support for descending sort order (#956)
768086f
SergeyKopienko pushed a commit that referenced this pull request Nov 8, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
d845d89
SergeyKopienko pushed a commit that referenced this pull request Nov 13, 2023
@akukanov @SergeyKopienko
[KT] Support for descending sort order (#956)
79da2be
dmitriy-sobolev pushed a commit that referenced this pull request Nov 16, 2023
@akukanov @dmitriy-sobolev
[KT] Support for descending sort order (#956)
39d1637
dmitriy-sobolev pushed a commit that referenced this pull request Nov 21, 2023
@akukanov @dmitriy-sobolev
[KT] Support for descending sort order (#956)
1fe8fdc
dmitriy-sobolev pushed a commit that referenced this pull request Nov 28, 2023
@akukanov @dmitriy-sobolev
[KT] Support for descending sort order (#956)
37ffefd
joeatodd pushed a commit to AidanBeltonS/oneDPL that referenced this pull request Dec 1, 2023
@akukanov @joeatodd
[KT] Support for descending sort order (oneapi-src#956)
ce2adee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKopienko SergeyKopienko SergeyKopienko approved these changes

@dmitriy-sobolev dmitriy-sobolev Awaiting requested review from dmitriy-sobolev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akukanov @SergeyKopienko