Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hipRAND backend #82

Closed
vrpascuzzi opened this issue Mar 13, 2021 · 7 comments
Closed

hipRAND backend #82

vrpascuzzi opened this issue Mar 13, 2021 · 7 comments
Labels
accepted The issue/feature is confirmed and going to be implemented backend A request to enable new implementation behind API

Comments

@vrpascuzzi
Copy link
Contributor

vrpascuzzi commented Mar 13, 2021

Summary

We have Intel CPU, GPU and cuRAND backends for the RNG domain. Let's do one more and support AMD GPUs as well. Note that this backend would require:

  • ROCm >= 3.5
  • HIP >= 3.5
  • llvm >= 11.0.0 (with AMDGPU target)
  • hipSYCL >= 0.9.0

Problem statement

oneMKL is missing RNG (and BLAS) for AMD GPUs.

Preferred solution

Add support for hipRAND. Given the uncanny resemblance to cuRAND, I expect this will be a trivial amount of work.

@vrpascuzzi
Copy link
Contributor Author

OK, the cmake part is a bit of a pain...

@vrpascuzzi
Copy link
Contributor Author

Got a couple generate functions added and the library compiles. Trying to figure out an issue linking against it.

@vrpascuzzi
Copy link
Contributor Author

Everything is in order now: compiling, linking, running.

@jasukhar jasukhar added accepted The issue/feature is confirmed and going to be implemented backend A request to enable new implementation behind API labels Mar 16, 2021
@illuhad
Copy link

illuhad commented Mar 25, 2021

@vrpascuzzi fyi, we are also working on hipSYCL support in oneMKL (focus on BLAS for now), including AMD support.

@vrpascuzzi
Copy link
Contributor Author

vrpascuzzi commented Mar 25, 2021

I have it done for AMD just waiting on copyright details (bit me once already).

@illuhad
Copy link

illuhad commented Aug 26, 2021

@vrpascuzzi Can you give an update on the hipRAND backend? Do you still plan on contributing this?

@mmeterel
Copy link
Contributor

@vrpascuzzi There is a PR to add rocRAND backend. #156
I will close this issue. Please feel free to re-open if you need to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted The issue/feature is confirmed and going to be implemented backend A request to enable new implementation behind API
Projects
None yet
Development

No branches or pull requests

4 participants