Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] run coverage for adapter tests #1165

Closed
wants to merge 1 commit into from

Conversation

pbalcer
Copy link
Contributor

@pbalcer pbalcer commented Dec 7, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1414e1) 15.80% compared to head (b2ca9fa) 15.80%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1165      +/-   ##
==========================================
- Coverage   15.80%   15.80%   -0.01%     
==========================================
  Files         223      223              
  Lines       31482    31481       -1     
  Branches     3558     3558              
==========================================
- Hits         4977     4976       -1     
  Misses      26454    26454              
  Partials       51       51              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pbalcer pbalcer force-pushed the more-coverage branch 9 times, most recently from c473e77 to 63ef1c2 Compare December 8, 2023 11:52
@pbalcer pbalcer force-pushed the more-coverage branch 4 times, most recently from b2ca9fa to 94bb7e6 Compare January 11, 2024 14:32
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this PR still valid? if so, please rebase

if: matrix.compiler.c == 'gcc'
continue-on-error: true
uses: codecov/codecov-action@eaaf4bedf32dbdc6b720b63067d99c4d77d6047d # v3.1.4
with:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could add flags: adapters to distinguish this from other coverage report(s)

@pbalcer
Copy link
Contributor Author

pbalcer commented Feb 2, 2024

is this PR still valid? if so, please rebase

it doesn't work because I can't get codecov to upload through the proxy:

Run codecov/codecov-action@eaaf4bedf32dbdc[6](https://github.com/oneapi-src/unified-runtime/actions/runs/7490304252/job/20388853697?pr=1165#step:11:7)b[7](https://github.com/oneapi-src/unified-runtime/actions/runs/7490304252/job/20388853697?pr=1165#step:11:8)20b63067d99c4d77d6047d
==> linux OS detected
Error: connect ETIMEDOUT 104.22.23.101:443
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1278:16)

Not really sure what's the issue. Didn't have much time to debug this.

@lukaszstolarczuk
Copy link
Contributor

is this PR still valid? if so, please rebase

it doesn't work because I can't get codecov to upload through the proxy:

Run codecov/codecov-action@eaaf4bedf32dbdc[6](https://github.com/oneapi-src/unified-runtime/actions/runs/7490304252/job/20388853697?pr=1165#step:11:7)b[7](https://github.com/oneapi-src/unified-runtime/actions/runs/7490304252/job/20388853697?pr=1165#step:11:8)20b63067d99c4d77d6047d
==> linux OS detected
Error: connect ETIMEDOUT 104.22.23.101:443
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1278:16)

Not really sure what's the issue. Didn't have much time to debug this.

ahh, I see. I quickly looked into it and I don't see the proxy param in the codecov action. There's an issue, I guess, confirming that: codecov/codecov-action#700 (comment) - leaving this for future ref.

@pbalcer
Copy link
Contributor Author

pbalcer commented Feb 2, 2024

They added proxy to the action in the version that this PR is using: https://github.com/codecov/codecov-action/tree/v3.1.4

But it doesn't seem to work. There's now v4 of this action, maybe it's fixed?

@pbalcer pbalcer closed this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants