-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] run coverage for adapter tests #1165
Conversation
e7629f4
to
1b59a74
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1165 +/- ##
==========================================
- Coverage 15.80% 15.80% -0.01%
==========================================
Files 223 223
Lines 31482 31481 -1
Branches 3558 3558
==========================================
- Hits 4977 4976 -1
Misses 26454 26454
Partials 51 51 ☔ View full report in Codecov by Sentry. |
c473e77
to
63ef1c2
Compare
b2ca9fa
to
94bb7e6
Compare
94bb7e6
to
04c81ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this PR still valid? if so, please rebase
if: matrix.compiler.c == 'gcc' | ||
continue-on-error: true | ||
uses: codecov/codecov-action@eaaf4bedf32dbdc6b720b63067d99c4d77d6047d # v3.1.4 | ||
with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could add flags: adapters
to distinguish this from other coverage report(s)
it doesn't work because I can't get codecov to upload through the proxy:
Not really sure what's the issue. Didn't have much time to debug this. |
ahh, I see. I quickly looked into it and I don't see the proxy param in the codecov action. There's an issue, I guess, confirming that: codecov/codecov-action#700 (comment) - leaving this for future ref. |
They added proxy to the action in the version that this PR is using: https://github.com/codecov/codecov-action/tree/v3.1.4 But it doesn't seem to work. There's now v4 of this action, maybe it's fixed? |
No description provided.