Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HIP] Handle required wg size attribute in HIP #954

Merged
merged 1 commit into from
May 20, 2024
Merged

[HIP] Handle required wg size attribute in HIP #954

merged 1 commit into from
May 20, 2024

Conversation

jchlanda
Copy link
Contributor

No description provided.

@jchlanda jchlanda requested a review from a team as a code owner October 12, 2023 10:16
@kbenzie
Copy link
Contributor

kbenzie commented Oct 12, 2023

[SYCL] prefix doesn't make much sense in this repo, should be [HIP] instead.

@jchlanda
Copy link
Contributor Author

Seems like build error is a blip in CI:

error: RPC failed; curl 56 GnuTLS recv error (-9): Error decoding the received TLS packet.
error: 15490 bytes of body are still expected

https://github.com/oneapi-src/unified-runtime/actions/runs/6494327570/job/17637060114?pr=954

@jchlanda
Copy link
Contributor Author

[SYCL] prefix doesn't make much sense in this repo, should be [HIP] instead.

Ha, ha, that's a leftover from intel/llvm. Will change.

@jchlanda jchlanda requested a review from a team as a code owner October 12, 2023 11:30
@jchlanda jchlanda changed the title [SYCL] Handle required wg size attribute in HIP [HIP] Handle required wg size attribute in HIP Oct 12, 2023
@kbenzie kbenzie requested review from a team and removed request for a team October 20, 2023 13:27
@jchlanda jchlanda marked this pull request as draft November 15, 2023 10:14
@jchlanda jchlanda force-pushed the jakub/rqwgs_hip branch 2 times, most recently from 04fe0f8 to bf9b8df Compare November 15, 2023 10:34
@jchlanda
Copy link
Contributor Author

This PR is blocked on the outcome of the discussion here: llvm/llvm-project#68872

@jchlanda jchlanda mentioned this pull request Nov 15, 2023
Draft
@fabiomestre fabiomestre changed the base branch from adapters to main December 5, 2023 16:54
@fabiomestre
Copy link
Contributor

I have updated the target branch of this PR from the adapters branch to the main branch.
Development in UR is moving back to main. The adapters branch will soon be deleted.

@kbenzie kbenzie added common Changes or additions to common utilities cuda CUDA adapter specific issues hip HIP adapter specific issues labels Apr 10, 2024
@jchlanda jchlanda force-pushed the jakub/rqwgs_hip branch 3 times, most recently from ddc5f94 to b98584f Compare April 30, 2024 12:18
@jchlanda jchlanda mentioned this pull request Apr 30, 2024
Merged
@jchlanda
Copy link
Contributor Author

Corresponding intel/llvm PR: intel/llvm#13600

@jchlanda jchlanda marked this pull request as ready for review April 30, 2024 12:53
@jchlanda jchlanda requested a review from hdelan May 6, 2024 08:47
hdelan
hdelan approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@hdelan hdelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making changes. LGTM

@jchlanda jchlanda force-pushed the jakub/rqwgs_hip branch 2 times, most recently from 12cb139 to 888694e Compare May 14, 2024 06:43
@kbenzie kbenzie added the ready to merge Added to PR's which are ready to merge label May 15, 2024
@jchlanda jchlanda requested a review from a team as a code owner May 16, 2024 09:40
PietroGhg
PietroGhg approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@PietroGhg PietroGhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Native CPU LGTM, thank you (the corresponding llvm PR may have to update the UR tag for native CPU)

@github-actions github-actions bot added the native-cpu Native CPU adapter specific issues label May 16, 2024
@jchlanda jchlanda force-pushed the jakub/rqwgs_hip branch 3 times, most recently from 3a6ab94 to 266d8bb Compare May 17, 2024 09:44
@jchlanda
[SYCL] Handle required wg size attribute in HIP
c893a3c 
Additionally, move split metadata to a common header accessible by all
backends.
@kbenzie kbenzie merged commit 8cdd099 into oneapi-src:main May 20, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PietroGhg PietroGhg PietroGhg approved these changes

@hdelan hdelan hdelan approved these changes

Assignees
No one assigned
Labels
common Changes or additions to common utilities cuda CUDA adapter specific issues hip HIP adapter specific issues native-cpu Native CPU adapter specific issues ready to merge Added to PR's which are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jchlanda @kbenzie @fabiomestre @PietroGhg @hdelan