Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prepare script #15

Merged
merged 1 commit into from
Oct 11, 2023
Merged

fix: prepare script #15

merged 1 commit into from
Oct 11, 2023

Conversation

inigomarquinez
Copy link
Member

@inigomarquinez inigomarquinez commented Oct 10, 2023

Description

  • fix prepare script to avoid it failing when husky is not present

Related Issue

#5

Motivation and Context

CI was failing because husky is a dev dependency and running prepare script fails only with production dependencies

https://typicode.github.io/husky/guide.html#with-a-custom-script

How Has This Been Tested?

No tests needed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@inigomarquinez inigomarquinez marked this pull request as draft October 11, 2023 11:47
@inigomarquinez inigomarquinez marked this pull request as ready for review October 11, 2023 11:47
@inigomarquinez inigomarquinez merged commit a585bf7 into main Oct 11, 2023
8 checks passed
@inigomarquinez inigomarquinez deleted the fix-prepare branch October 11, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants