Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

Hapi 12+ and yar bug fix #13

Open
pabshazon opened this issue Apr 10, 2016 · 5 comments
Open

Hapi 12+ and yar bug fix #13

pabshazon opened this issue Apr 10, 2016 · 5 comments

Comments

@pabshazon
Copy link

From https://github.com/hapijs/yar

Starting with Hapi 12 the request.session placeholder was removed.
The guidance from Hapi maintainer Eran Hammer was for this and similar modules to move data storage away from request.session and use a more unique location. So, starting in 6.x.x the yar storage has been moved to request.yar

My solution:

index.js line 201 should be:
request.yar.lazy(true);

index.js line 206 should be:
session: request.yar,

Maybe you prefer a different approach to solve the issue

@devinivy
Copy link
Collaborator

Thanks! This module does require a little bit of maintenance right now to bring it up-to-date.

@pabshazon
Copy link
Author

Come on, we can resurrect it :)

@devinivy
Copy link
Collaborator

I don't think it will take much work, aside from the fact that it's officially time to write some proper tests for this plugin!

@pabshazon
Copy link
Author

@devinivy, I can take care of the testing.
What testing libraries would you use?
I like Jasmine + Frisby but they might not be the best to test chained calls... any library recommendation to dev the tests for the Oauth2 process?

@devinivy
Copy link
Collaborator

@pabshazon I would personally use lab!

guillaumev added a commit to UN-OCHA/hapi-oauth2orize that referenced this issue Nov 9, 2016
ecstasy2 added a commit to edyn/hapi-oauth2orize that referenced this issue Jan 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants