#118 Save logs related to party member before its death

CHANGELOG.md

@@ -1,4 +1,8 @@
-### v2.9.0
+### v2.10.0
+
+* [#118](https://github.com/onechiporenko/my-dungeons-book/issues/118) Save logs related to party member before its death
+
+### v2.9.0
 
 * Track friendly fire damage separately
 * Improve Equip tab (show rings, trinkets and weapon separately)

Events.lua

@@ -27,24 +27,27 @@ function MyDungeonsBook:COMBAT_LOG_EVENT_UNFILTERED()
 		self:TrackSummonnedByPartyMembersUnit(srcName, srcGUID, dstName, dstGUID);
 	end
 	if (subEventName == "UNIT_DIED") then
-		self:TrackDeath(dstGUID, dstName);
-		self:TrackSummonByPartyMemberUnitDeath(dstGUID, dstName);
+		self:TrackDeath(timestamp, dstName, dstGUID);
+		self:TrackSummonByPartyMemberUnitDeath(dstName, dstGUID);
 		self:TrackEnemyUnitDied(dstName, dstGUID, dstFlags);
 		self:RemoveAurasFromPartyMember(dstName, dstGUID);
+		self:SaveDeathLogsForPartyMember(timestamp, dstName);
 	end
 	if (subEventName == "UNIT_DESTROYED") then
-		self:TrackSummonByPartyMemberUnitDeath(dstGUID, dstName);
+		self:TrackSummonByPartyMemberUnitDeath(dstName, dstGUID);
 	end
 	if (subEventSuffix == "HEAL") then
 		local spellId, _, _, amount, overheal, _, crit = select(12, CombatLogGetCurrentEventInfo());
 		self:TrackAllHealDoneByPartyMembersToEachOther(srcName, srcGUID, dstName, dstGUID, spellId, amount, overheal);
 		self:TrackAllHealBySpellDoneByPartyMembers(srcName, srcGUID, srcFlags, dstName, dstGUID, dstFlags, spellId, amount, overheal, crit);
+		self:TrackCombatEventWithPartyMember(timestamp, dstName, dstGUID);
 	end
 	if (subEventName == "DAMAGE_SPLIT" or
 		subEventName == "DAMAGE_SHIELD") then
 		local spellId, _, _, amount, overheal = select(12, CombatLogGetCurrentEventInfo());
 		self:TrackAllHealDoneByPartyMembersToEachOther(srcName, srcGUID, dstName, dstGUID, spellId, amount, overheal);
 		self:TrackAllHealBySpellDoneByPartyMembers(srcName, srcGUID, srcFlags, dstName, dstGUID, dstFlags, spellId, amount, overheal, false);
+		self:TrackCombatEventWithPartyMember(timestamp, dstName, dstGUID);
 	end
 	if (subEventName == "SPELL_ABSORBED") then
 		local unitGUID, unitName, unitFlags, _, spellId, _, _, amount = select(12, CombatLogGetCurrentEventInfo());
@@ -54,6 +57,7 @@ function MyDungeonsBook:COMBAT_LOG_EVENT_UNFILTERED()
 		end
 		self:TrackAllHealDoneByPartyMembersToEachOther(unitName, unitGUID, dstName, dstGUID, spellId, amount, -1);
 		self:TrackAllHealBySpellDoneByPartyMembers(unitName, unitGUID, unitFlags, dstName, dstGUID, dstFlags, spellId, amount, -1, false);
+		self:TrackCombatEventWithPartyMember(timestamp, dstName, dstGUID);
 	end
 	if (subEventSuffix == "INTERRUPT") then
 		local spellId, _, _, extraSpellId = select(12, CombatLogGetCurrentEventInfo());
@@ -63,6 +67,7 @@ function MyDungeonsBook:COMBAT_LOG_EVENT_UNFILTERED()
 		subEventName == "SPELL_STOLEN") then
 		local spellId, _, _, extraSpellId = select(12, CombatLogGetCurrentEventInfo());
 		self:TrackDispel(srcName, srcGUID, spellId, extraSpellId, dstFlags2);
+		self:TrackCombatEventWithPartyMember(timestamp, dstName, dstGUID);
 	end
 	if (subEventName == "SPELL_CAST_SUCCESS") then
 		local spellId = select(12, CombatLogGetCurrentEventInfo());
@@ -80,12 +85,14 @@ function MyDungeonsBook:COMBAT_LOG_EVENT_UNFILTERED()
 		self:TrackAllDamageDoneToPartyMembers(srcName, dstName, srcGUID, spellId, amount);
 		self:TrackAllDamageDoneByPartyMembers(srcName, srcGUID, srcFlags, dstName, dstGUID, dstFlags, spellId, amount, overkill, crit);
 		self:TrackSLDamageDoneToSpecificUnits(srcName, srcGUID, spellId, amount, overkill, dstName, dstGUID);
+		self:TrackCombatEventWithPartyMember(timestamp, dstName, dstGUID);
 	end
 	if (subEventName == "SWING_DAMAGE") then
 		local amount, overkill, _, _, _, _, crit = select(12, CombatLogGetCurrentEventInfo());
 		self:TrackAllDamageDoneToPartyMembers(srcName, dstName, srcGUID, -2, amount);
 		self:TrackAllDamageDoneByPartyMembers(srcName, srcGUID, srcFlags, dstName, dstGUID, dstFlags, -2, amount, overkill, crit);
 		self:TrackSLDamageDoneToSpecificUnits(srcName, srcGUID, -2, amount, overkill, dstName, dstGUID);
+		self:TrackCombatEventWithPartyMember(timestamp, dstName, dstGUID);
 	end
 	if (subEventName == "SPELL_EXTRA_ATTACKS") then
 		local amount = select(12, CombatLogGetCurrentEventInfo());
@@ -106,6 +113,7 @@ function MyDungeonsBook:COMBAT_LOG_EVENT_UNFILTERED()
 		self:TrackAllBuffOrDebuffOnUnit(dstName, dstGUID, dstFlags, spellId, auraType, amount or 1);
 		self:TrackAuraAddedToPartyMember(dstName, dstGUID, spellId, auraType, amount or 1);
 		self:TrackAuraAddedToEnemyUnit(srcName, srcGUID, srcFlags, dstName, dstGUID, dstFlags, spellId, auraType, amount or 1);
+		self:TrackCombatEventWithPartyMember(timestamp, dstName, dstGUID);
 	end
 	if (subEventName == "SPELL_AURA_REMOVED" or
 		subEventName == "SPELL_AURA_REMOVED_DOSE" or
@@ -115,6 +123,7 @@ function MyDungeonsBook:COMBAT_LOG_EVENT_UNFILTERED()
 		self:TrackAuraRemovedFromPartyMember(dstName, dstGUID, spellId, auraType, amount or 0);
 		self:TrackAuraRemovedFromEnemyUnit(dstName, dstGUID, spellId, auraType, amount or 0);
 		self:TrackSLSpecificBuffOrDebuffRemovedFromUnit(dstName, dstGUID, dstFlags, spellId, auraType, amount or 0);
+		self:TrackCombatEventWithPartyMember(timestamp, dstName, dstGUID);
 	end
 end
 
@@ -135,6 +144,7 @@ function MyDungeonsBook:CHALLENGE_MODE_START()
 	self:RegisterEvent("PLAYER_REGEN_DISABLED");
 	self:RegisterEvent("PLAYER_REGEN_ENABLED");
     self:DebugPrint("CHALLENGE_MODE_START");
+	wipe(self.allPartyMemberLogs or {});
 	if (self.partyAliveStatusCheckTimer) then
 		self:CancelTimer(self.partyAliveStatusCheckTimer);
 	end
@@ -293,6 +303,7 @@ function MyDungeonsBook:CHALLENGE_MODE_COMPLETED()
 	end
 	self:UnregisterEvent("PLAYER_REGEN_DISABLED");
 	self:UnregisterEvent("PLAYER_REGEN_ENABLED");
+	wipe(self.allPartyMemberLogs or {});
 end
 
 --[[--

Locales/enUS.lua

@@ -151,6 +151,9 @@ L["Critical Strike"] = "Critical Strike";
 L["Haste"] = "Haste";
 L["Mastery"] = "Mastery";
 L["Versatility"] = "Versatility";
+L["Event"] = "Event";
+L["Source"] = "Source";
+L["HP"] = "HP";
 -- UI end
 
 -- Help start
@@ -191,6 +194,8 @@ L["Release Time"] = "Release Time";
 L["Time dead"] = "Time dead";
 L["%s (start)"] = "%s (start)";
 L["%s (end)"] = "%s (end)";
+L["Death logs"] = "Death logs";
+L["Time before death to track"] = "Time before death to track";
 -- Settings end
 
 -- Regex start (thanks to Exorsus Raid Tool)

Locales/ruRU.lua

@@ -152,6 +152,9 @@ L["Critical Strike"] = "Критический удар";
 L["Haste"] = "Скорость";
 L["Mastery"] = "Искусность";
 L["Versatility"] = "Универсальность";
+L["Event"] = "Событие";
+L["Source"] = "Источник";
+L["HP"] = "Здоровье";
 -- UI end
 
 -- Help start
@@ -163,7 +166,7 @@ L["send some message via comm to other MDB user. unitId must be 'party1..4'."] =
 
 -- Settings start
 L["Performance"] = "Производительность";
-L["Run garbage collector on close"] = "Выполнять сборку мусору при закрытии MDB";
+L["Run garbage collector on close"] = "Выполнять сборку мусора при закрытии MDB";
 L["Show DEV Tab"] = "Выводить DEV-вкладку";
 L["Verbose"] = "Verbose";
 L["Show DEBUG messages"] = "Выводить DEBUG-сообщения";
@@ -192,6 +195,8 @@ L["Release Time"] = "Время воскрешения";
 L["Time dead"] = "Время мертвым";
 L["%s (start)"] = "%s (начало)";
 L["%s (end)"] = "%s (конец)";
+L["Death logs"] = "Логи смертей";
+L["Time before death to track"] = "Сколько записывать времени перед смертью";
 -- Settings end
 
 -- Regex start (thanks to Exorsus Raid Tools)

Mechanics/Common.lua

@@ -13,6 +13,8 @@ local L = LibStub("AceLocale-3.0"):GetLocale("MyDungeonsBook");
 
 local petTooltipFrame = CreateFrame("GameTooltip", "MyDungeonsBookPetTooltip", nil, "GameTooltipTemplate");
 
+local allPartyMemberLogs = {};
+
 --[[--
 Original idea is taken from Details addon
 
@@ -180,38 +182,39 @@ end
 --[[--
 Track each player's death.
 
-@param[type=GUID] deadUnitGUID 8th result of `CombatLogGetCurrentEventInfo` call
+@param[type=number] timestamp 1st result of `CombatLogGetCurrentEventInfo` call
 @param[type=string] unit 9th result of `CombatLogGetCurrentEventInfo` call
+@param[type=GUID] deadUnitGUID 8th result of `CombatLogGetCurrentEventInfo` call
 ]]
-function MyDungeonsBook:TrackDeath(deadUnitGUID, unit)
+function MyDungeonsBook:TrackDeath(timestamp, deadUnitName, deadUnitGUID)
 	local id = self.db.char.activeChallengeId;
-	local isPlayer = strfind(deadUnitGUID, "Player"); -- needed GUID is something like "Player-......"
-	if (not isPlayer) then
+	if (not UnitIsPlayer(deadUnitName)) then
 		return;
 	end
-	if (UnitIsFeignDeath(unit)) then
-		self:DebugPrint(string.format("%s is feign death", unit));
+	if (UnitIsFeignDeath(deadUnitName)) then
+		self:DebugPrint(string.format("%s is feign death", deadUnitName));
 	    return;
 	end
 	local surrenderedSoul = GetSpellInfo(212570);
 	for i = 1, 40 do
-		local debuffName = UnitDebuff(unit, i);
+		local debuffName = UnitDebuff(deadUnitName, i);
 		if (debuffName == nil) then
 			break;
 		end
 		if (debuffName == surrenderedSoul) then
-			self:DebugPrint(string.format("%s is on Surrendered Soul debuff", unit));
+			self:DebugPrint(string.format("%s is on Surrendered Soul debuff", deadUnitName));
 			return;
 		end
 	end
 	local key = "DEATHS";
-	self:InitMechanics2Lvl(key, unit);
-	tinsert(self.db.char.challenges[id].mechanics[key][unit], time());
+	self:InitMechanics2Lvl(key, deadUnitName);
+	tinsert(self.db.char.challenges[id].mechanics[key][deadUnitName], {original = timestamp, rounded = floor(timestamp), ["local"] = time()});
 	self.db.char.challenges[id].challengeInfo.numDeaths = self.db.char.challenges[id].challengeInfo.numDeaths + 1;
 	if (self.db.global.meta.mechanics[key].verbose) then
-		self:LogPrint(string.format(L["%s died"], self:ClassColorText(unit, unit)));
+		self:LogPrint(string.format(L["%s died"], self:ClassColorText(deadUnitName, deadUnitName)));
 	end
-	self:RemoveAurasFromPartyMember(unit, deadUnitGUID);
+	-- Force to update internal death timers
+	self:PartyAliveStatusCheck();
 end
 
 --[[--
@@ -1332,3 +1335,64 @@ function MyDungeonsBook:AddAurasToPartyMember(sourceUnitName, unitId)
 		self:TrackAuraAddedToPartyMember(sourceUnitName, UnitGUID(unitId), spellId, "DEBUFF", (amount == 0 and 1) or amount);
 	end
 end
+
+--[[--
+Track all combat logs related to party members
+
+@param[type=timestamp] number
+@param[type=string] unitName
+]]
+function MyDungeonsBook:TrackCombatEventWithPartyMember(timestamp, unitName, unitGUID)
+	if (not UnitIsPlayer(unitName)) then
+		return;
+	end
+	local ts = floor(timestamp);
+	local id = self.db.char.activeChallengeId;
+	self.allPartyMemberLogs = self.allPartyMemberLogs or {};
+	self.allPartyMemberLogs[unitName] = self.allPartyMemberLogs[unitName] or {};
+	self.allPartyMemberLogs[unitName][ts] = self.allPartyMemberLogs[unitName][ts] or {};
+	local unitId = self:GetPartyUnitByName(id, unitName);
+	local meta = {
+		hp = {
+			max = UnitHealthMax(unitId),
+			current = UnitHealth(unitId)
+		}
+	};
+	local log = {CombatLogGetCurrentEventInfo()};
+	tinsert(log, 1, meta);
+	tinsert(self.allPartyMemberLogs[unitName][ts], log);
+end
+
+--[[--
+Save separately combat logs related for party member (last N seconds before death)
+
+@param[type=timestamp] number
+@param[type=string] unitName
+]]
+function MyDungeonsBook:SaveDeathLogsForPartyMember(timestamp, unitName)
+	if (not UnitIsPlayer(unitName)) then
+		return;
+	end
+	if (UnitIsFeignDeath(unitName)) then
+		return;
+	end
+	local logs = self.allPartyMemberLogs[unitName];
+	if (not logs) then
+		return;
+	end
+	local ts = floor(timestamp);
+	local KEY = "PARTY-MEMBER-DEATH-LOGS";
+	local id = self.db.char.activeChallengeId;
+	if (not id) then
+		return;
+	end
+	self:InitMechanics3Lvl(KEY, unitName, ts);
+	for i = ts - self.db.global.meta.mechanics["PARTY-MEMBER-DEATH-LOGS"].timeBeforeDeathToTrack, ts + 1 do
+		if (logs[i]) then
+			for _, log in pairs(logs[i]) do
+				tinsert(self.db.char.challenges[id].mechanics[KEY][unitName][ts], self:CopyTable(log));
+			end
+		end
+	end
+	wipe(self.allPartyMemberLogs[unitName]);
+end

Mechanics/SL/Common.lua

@@ -728,6 +728,14 @@ function MyDungeonsBook:GetSLAvoidableSpellsNoTank()
     return SLSpellsNoTank;
 end
 
+function MyDungeonsBook:GetSLAvoidableAuras()
+    return SLAuras;
+end
+
+function MyDungeonsBook:GetSLAvoidableAurasNoTank()
+    return SLAurasNoTank;
+end
+
 function MyDungeonsBook:TrackSLAvoidableSpells(damagedUnit, spellId, amount)
 	self:TrackAvoidableSpells("SL-AVOIDABLE-SPELLS", SLSpells, SLSpellsNoTank, damagedUnit, spellId, amount);
 end

Options.lua

@@ -184,6 +184,10 @@ MyDungeonsBook.OptionsDefaults = {
 				},
 				["SL-DAMAGE-DONE-TO-UNITS"] = {
 					id = "SL-DAMAGE-DONE-TO-UNITS"
+				},
+				["PARTY-MEMBER-DEATH-LOGS"] = {
+					id = "PARTY-MEMBER-DEATH-LOGS",
+					timeBeforeDeathToTrack = 15
 				}
 			},
 		}
@@ -288,7 +292,7 @@ MyDungeonsBook.Options = {
 			}
 		},
 		verbose = {
-			order = 1,
+			order = 2,
 			name = L["Verbose"],
 			type = "group",
 			args = {
@@ -421,7 +425,7 @@ MyDungeonsBook.Options = {
 			}
 		},
 		performance = {
-			order = 2,
+			order = 3,
 			name = L["Performance"],
 			type = "group",
 			args = {
@@ -457,7 +461,7 @@ MyDungeonsBook.Options = {
 			type = "group",
 			args = {
 				mechanics = {
-					name = "Mechanics",
+					name = L["Mechanics"],
 					inline = true,
 					type = "group",
 					args = {
@@ -481,6 +485,34 @@ MyDungeonsBook.Options = {
 					}
 				}
 			}
+		},
+		mechanics = {
+			order = 5,
+			name = L["Mechanics"],
+			type = "group",
+			args = {
+				deathlogs = {
+					name = L["Death logs"],
+					type = "group",
+					args = {
+						timeBeforeDeathToTrack = {
+							order = 1,
+							name = L["Time before death to track"],
+							type = "range",
+							width = "full",
+							min = 5,
+							max = 15,
+							step = 1,
+							get = function()
+								return MyDungeonsBook.db.global.meta.mechanics["PARTY-MEMBER-DEATH-LOGS"].timeBeforeDeathToTrack;
+							end,
+							set = function(_, v)
+								MyDungeonsBook.db.global.meta.mechanics["PARTY-MEMBER-DEATH-LOGS"].timeBeforeDeathToTrack = v;
+							end
+						}
+					}
+				}
+			}
 		}
 	}
 };

UI/ChallengeDetails/Tabs/Encounters.lua

@@ -46,7 +46,7 @@ function getSuccessFailIcon(success)
 		icon = "interface\\raidframe\\readycheck-notready.blp";
 	end
 	local suffix = MyDungeonsBook:GetIconTextureSuffix(16);
-	return "|T" .. (icon or "") .. suffix .. "|t"
+	return "|T" .. (icon or "") .. suffix .. "|t";
 end
 
 --[[--

UI/ChallengeDetails/Tabs/Mechanics/Tabs/Damage/Tabs/DamageDoneToPartyMembers.lua

@@ -248,7 +248,7 @@ function MyDungeonsBook:DamageDoneToPartyMembersFrame_Report_Create(row, cols)
 		spellLinkOrName = GetSpellLink(row.cols[1].value);
 	else
 		local npcId = math.abs(spellId);
-		local cellText = L["Swing Damage"];
+		local cellText = (spellId == -3 and L["Avoidable"]) or L["Swing Damage"];
 		local unitName = (self.db.global.meta.npcs[npcId] and self.db.global.meta.npcs[npcId].name) or npcId;
 		spellLinkOrName = string.format("%s (%s)", cellText, unitName);
 	end