Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for customizing sample labels #221

Closed
clausmith opened this issue Mar 1, 2019 · 2 comments
Closed

Add support for customizing sample labels #221

clausmith opened this issue Mar 1, 2019 · 2 comments
Assignees
Milestone

Comments

@clausmith
Copy link
Contributor

A user should be able to customize how the samples are labelled along an axis. For example, specifying that the plot be labelled by external_sample_id, or a lambda function.

@polyatail
Copy link
Contributor

Technically, this still exists by calling, for example:

# method 1
samples._collate_metadata(label="metadata field")

# method 2
samples._collate_metadata(label=lambda metadata: "my formatter {}".format(metadata.field))
samples.plot_pca()

But I agree that it should be made more accessible. Perhaps making collate_metadata public?

@polyatail polyatail self-assigned this Mar 1, 2019
@boydgreenfield
Copy link
Contributor

@polyatail I’d error towards making this doable in the plot_* calls directly. Seems like exposing metadata collation is quickly getting into “expert end user” territory and I think a wider audience would like/use this functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants