Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return ResourceList object instead of list in API #129

Merged
merged 2 commits into from
Nov 17, 2018
Merged

Conversation

polyatail
Copy link
Contributor

This pull request addresses #40:

  • Adds a new object type, ResourceList, that emulates a list but passes actions performed on items along to the underlying Resource object.
  • Implements insert, append, extend, pop, remove, count, setting/getting/deleting by index
  • Explicitly disallows non-equivalence comparisons (e.g., greater than or less than) in ResourceList and objects derived from OneCodexBase
  • Tests list emulation and comparisons in test_api_models

* Explicitly disallow unsupported comparisons between API models
* Added tests for ResourceLists, and comparison between models
@polyatail polyatail self-assigned this Nov 17, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 83.977% when pulling 191d352 on roo-apilist into a4b9eb4 on master.

@boydgreenfield boydgreenfield merged commit 282080a into master Nov 17, 2018
@boydgreenfield boydgreenfield deleted the roo-apilist branch November 17, 2018 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants