Pull schema from mainline API in one shot #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sweet! Let's review on Monday and merge. This should give a nice boost to initialization time and feel. :) |
boydgreenfield
force-pushed
the
master
branch
from
2455ddc
to
c922835
Compare
* Fetch schema in one shot using ?expand=all * Update tests and data to latest API schema version * Remove vestigial test_api.py
boydgreenfield
force-pushed
the
roo-kiwi2
branch
from
d2d4bd3
to
3eede71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issue:
#156 Rather than loading individual model schemas one at a time, pull them all at once by passing
?expand=allTest data has been updated to the schema pulled from the API at the time of this PR, and tests were updated accordingly.