Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to a single namespaced logger for both CLI and API #281

Merged
merged 2 commits into from
Jul 19, 2019
Merged

Switch to a single namespaced logger for both CLI and API #281

merged 2 commits into from
Jul 19, 2019

Conversation

polyatail
Copy link
Contributor

This PR closes #254 by using the onecodex namespaced logger throughout the library. We switch the format of the log to one without timestamps in cli.py, and only when actually executed from the command line (not at import time).

@polyatail polyatail added this to the Sprint Caramel milestone Jul 19, 2019
@polyatail polyatail self-assigned this Jul 19, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 83.82% when pulling acc44da on roo-logger into 287f7a5 on master.

@polyatail polyatail merged commit c46241b into master Jul 19, 2019
@polyatail polyatail deleted the roo-logger branch July 19, 2019 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boydgreenfield boydgreenfield Awaiting requested review from boydgreenfield

Assignees

@polyatail polyatail

Labels
None yet
Projects
None yet
Milestone
Sprint Caramel
Development

Successfully merging this pull request may close these issues.

Move logger configuration into CLI initialization vs. in cli.py
2 participants
@polyatail @coveralls