New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bootstrap] fix: Fixed required variable validation assertions #1077

Merged

onedr0p merged 2 commits into onedr0p:main from gregmulvaney:main

Dec 8, 2023

Contributor

gregmulvaney commented Dec 8, 2023

Turns out it was much simpler than I originally thought.

item in vars checks that the variable exists in the vars object
vars[item] != None checks that the variable is set

Empty variables are assigned as null by Ansible which Python then translates into None.

gregmulvaney added 2 commits

December 8, 2023 08:57


          Fixed required variable validation

bab7fda


          Fixed fix

2c127c6

github-actions bot added the area/bootstrap label

onedr0p approved these changes

View reviewed changes

onedr0p merged commit 03f39e9 into onedr0p:main

1 check passed

Owner

onedr0p commented Dec 8, 2023

That makes sense, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment