Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use makejinja to template out configuration #1154

Closed
wants to merge 1 commit into from
Closed

Conversation

onedr0p
Copy link
Owner

@onedr0p onedr0p commented Jan 14, 2024

Testing the waters with makejinja over ansible for templating...

Benefits:

  • Way... way... way faster than Ansible at templating.
  • Able to template out files without needing to separate addons in the templates folder or k0s/k3s ansible folders, the file contents just need to be wrapped in a jinja if block.

Drawbacks:

  • Validation is still done with ansible
  • Loss of certain functions of ansible like nthhost and password_hash

Signed-off-by: Devin Buhl <devin@buhl.casa>
@github-actions github-actions bot added area/kubernetes Changes made in the kubernetes directory area/ansible area/bootstrap Changes made in the bootstrap directory area/taskfile labels Jan 14, 2024
@onedr0p onedr0p marked this pull request as draft January 14, 2024 20:52
@onedr0p onedr0p closed this Jan 14, 2024
@onedr0p
Copy link
Owner Author

onedr0p commented Jan 14, 2024

I am going to circle back to this some day if we really need to improve the speed of templating. Ansible is slow but it's an AIO solution for validation and templating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bootstrap Changes made in the bootstrap directory area/kubernetes Changes made in the kubernetes directory area/taskfile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant