Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to python for data validation #1214

Merged
merged 6 commits into from
Jan 21, 2024
Merged

feat: migrate to python for data validation #1214

merged 6 commits into from
Jan 21, 2024

Conversation

onedr0p
Copy link
Owner

@onedr0p onedr0p commented Jan 21, 2024

This completely removes Ansible for data validation of the config.yaml and instead wraps validation while running makejinja.

Important Changes:

  • task init installs the venv
  • Ansible requirements.yaml and requirements.txt are templated to jinja and moved into the bootstrap/templates/ansible folder
  • task ansible:deps installs the specific Ansible deps for the venv

Todo:

  • Add validation for bootstrap_nodes
  • Add validation for checking if the age key exists on filesystem (done is taskfile)
  • Update readme

Signed-off-by: Devin Buhl <devin@buhl.casa>
@github-actions github-actions bot added area/github Changes made in the github directory area/bootstrap Changes made in the bootstrap directory area/taskfile labels Jan 21, 2024
@onedr0p onedr0p marked this pull request as draft January 21, 2024 01:20
Signed-off-by: Devin Buhl <devin@buhl.casa>
Signed-off-by: Devin Buhl <devin@buhl.casa>
Signed-off-by: Devin Buhl <devin@buhl.casa>
Signed-off-by: Devin Buhl <devin@buhl.casa>
Signed-off-by: Devin Buhl <devin@buhl.casa>
@onedr0p onedr0p marked this pull request as ready for review January 21, 2024 13:31
@onedr0p onedr0p merged commit b89b7b3 into main Jan 21, 2024
7 checks passed
@onedr0p onedr0p deleted the python-validation branch January 21, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bootstrap Changes made in the bootstrap directory area/github Changes made in the github directory area/taskfile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants