Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rename addon vars to addon_ prefix and simplify logic in jinja templates #1216

Merged
merged 1 commit into from
Jan 21, 2024
Merged

feat: rename addon vars to addon_ prefix and simplify logic in jinja templates #1216

merged 1 commit into from
Jan 21, 2024

Conversation

onedr0p
Copy link
Owner

@onedr0p onedr0p commented Jan 21, 2024 •
edited

All these changes makes the templates easier to read when looking at the logic.

  • No more need to use defaults in jinja logic
  • Rename addons vars to add a addon_ prefix

@onedr0p
feat: implement makejinja chainable undefined arg
0801b44 
Signed-off-by: Devin Buhl <devin@buhl.casa>
@github-actions github-actions bot added area/github Changes made in the github directory area/bootstrap Changes made in the bootstrap directory labels Jan 21, 2024
@onedr0p onedr0p changed the title feat: rename addon vars to addon_ prefix and implement makejinja chainable undefined arg feat: rename addon vars to addon_ prefix and simplify logic in jinja templates Jan 21, 2024
@onedr0p onedr0p merged commit db21ea8 into main Jan 21, 2024
7 checks passed
@onedr0p onedr0p deleted the chainable branch January 21, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/bootstrap Changes made in the bootstrap directory area/github Changes made in the github directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@onedr0p