Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extensionServices to be specified #1496

Merged
merged 2 commits into from
May 28, 2024

Conversation

wasurerarenai
Copy link
Contributor

Similar to #1495 (which didn't support talenv.sops.yaml envsubst), this adds further support for budimanjojo/talhelper#431. With talenv envsubst, secrets can be encrypted, and automatically referenced when talhelper genconfig is ran. This patch adds support for talhelper's extensionServices inclusions.

extraManifests is still useful for adding manifests like v1.7's WatchdogTimerConfig.

Example config.yaml

bootstrap_node_inventory:
  - name: node1
...
    extension_services:
      - name: nut-client
        configFiles:
          - content: MONITOR ${upsmonUpsName}@${upsmonHost}:${upsmonPort} 1 ${upsmonUser} ${upsmonPasswd} slave
            mountPath: /usr/local/etc/nut/upsmon.conf
        environment:
          - UPS_NAME=ups

Results in talconfig.yaml

nodes:
  - hostname: "node1"
...
    extensionServices:
      - name: nut-client
        configFiles:
          - content: |-
              MONITOR ${upsmonUpsName}@${upsmonHost}:${upsmonPort} 1 ${upsmonUser} ${upsmonPasswd} slave
            mountPath: /usr/local/etc/nut/upsmon.conf
        environment:
          - UPS_NAME=ups

When supplied with the talenv.sops.yaml contents:

upsmonHost: 192.168.1.10
upsmonPasswd: password
upsmonPort: 3493
upsmonUpsName: ups
upsmonUser: username

Renders clusterconfig files with:

version: v1alpha1
...
  network:
    hostname: node1
...
  allowSchedulingOnControlPlanes: true
---
apiVersion: v1alpha1
kind: ExtensionServiceConfig
name: nut-client
configFiles:
  - content: MONITOR ups@192.168.1.10:3493 1 username password slave
    mountPath: /usr/local/etc/nut/upsmon.conf
environment:
  - UPS_NAME=ups

Allow extensionServices to be specified
Allow extensionServices to be specified
@github-actions github-actions bot added the area/bootstrap Changes made in the bootstrap directory label May 28, 2024
@onedr0p onedr0p merged commit cfb3d8e into onedr0p:main May 28, 2024
2 checks passed
@wasurerarenai wasurerarenai deleted the wasurerarenai-patch-1 branch May 28, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bootstrap Changes made in the bootstrap directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants