fix: Adds missing kustomize for k8s-dashboard #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also adds base64 decode to comment in rbac
|
@axeII there's no need for a kustomization file there since the ks.yaml in being applied in the parent directory. I'm not sure why that wouldn't deploy for you but I don't think that was the issue. I've deleted that kustomization and kept the comment update. Thanks! |
|
Yeah you are right! I missed that one since in my repo I didn't apply the ks.yaml directly but the root directory of ks.yaml which is why kustomize didn't apply whole dashboard. Well TIL you can do that with kustomize. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Devin,
when I tried to deploy kubernetes-dashboard I was following your template. However the dashboard was not deployed - I found there is a missing
Kustomizationfile.This PR also adds step
base64 -dto the comment for getting secret token for login to dashboard in the filerbac.yaml. Reason for that is that when I tried the original secret returned by k8s I wasn't able to login and had to decoded the secret as base64. After that I was able to login via the secret token.Let me know what do you think about these changes.
Cheers.