Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for cluster user secrets and settings #858

Merged
merged 18 commits into from
Jul 24, 2023

Conversation

aumer-amr
Copy link
Sponsor Contributor

This allows for adding extra cluster-secrets to your cluster, without any chance of overriding them accidently.
Since ansible will now always check if the file cluster-secrets-extra.yaml already exists or no.

@aumer-amr
Copy link
Sponsor Contributor Author

Note im deffo not an ansible person, so there are more likely better ways.

@onedr0p
Copy link
Owner

onedr0p commented Jul 18, 2023

I have a few ideas / questions

  1. How do you feel about cluster-secrets-user instead of cluster-secrets-extra ? and we could also do a cluster-settings-user to supplement this change.

  2. I'm also curious if that we need to update the bootstrap task in taskfiles to include these new files?

https://github.com/onedr0p/flux-cluster-template/blob/main/.taskfiles/ClusterTasks.yaml#L12L17

@aumer-amr
Copy link
Sponsor Contributor Author

I liked the user part, and switched towards that naming scheme. I also added the settings file.
I included it into the task file there, so it will always be applied when normal settings will also be applied. It wasn't really necessary from what i found, more like optional.

I did run into an issue with the line item.path not is match('cluster-(settings|secrets)-user\.yaml\.j2') when i tried it on 2 different machines (vm's though), so please check it.

Copy link
Owner

@onedr0p onedr0p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits here but overall looking good.

.taskfiles/ClusterTasks.yaml Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
bootstrap/tasks/kubernetes/main.yaml Outdated Show resolved Hide resolved
bootstrap/tasks/kubernetes/main.yaml Outdated Show resolved Hide resolved
bootstrap/tasks/kubernetes/main.yaml Outdated Show resolved Hide resolved
bootstrap/tasks/kubernetes/main.yaml Outdated Show resolved Hide resolved
bootstrap/tasks/kubernetes/main.yaml Outdated Show resolved Hide resolved
onedr0p and others added 2 commits July 24, 2023 16:05
Signed-off-by: Devin Buhl <devin@buhl.casa>
@onedr0p onedr0p changed the title feat: Cluster secrets extra feat: add support for cluster user secrets and settings Jul 24, 2023
@onedr0p onedr0p merged commit 1f55147 into onedr0p:main Jul 24, 2023
1 check passed
@aumer-amr
Copy link
Sponsor Contributor Author

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants