Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Switch to official env var support for radarr, sonarr, prowlarr readarr and lidarr #1013

Closed
4 of 5 tasks
onedr0p opened this issue Apr 28, 2024 · 8 comments
Closed
4 of 5 tasks

Comments

@onedr0p
Copy link
Owner

onedr0p commented Apr 28, 2024

Important

The containers below will be modified after their stable release is cut with the env changes, and it will be a breaking change. The entrypoint.sh script will be simplified and xmlstarlet, envsubst will be removed. I will do my best to update this issue when this happens. I urge people to subscribe to this issue for updates.

These apps will start to begin to support env var for config.xml items.

  • Sonarr
  • Radarr
  • Lidarr
  • Prowlarr
  • Readarr

I also recommend people to switch to the new environment variables as soon as it's supported upstream on your given branch. This will ensure you don't have any issues once the old envsubt method is gone.

You can see an example I did here with Sonarr/develop.

I apologize in advance for any one who does not notice or pay attention to this issue when the breaking changes occur.

@onedr0p onedr0p changed the title Deprecate envsubt methods in radarr, sonarr, prowlarr and lidarr Deprecate envsubt methods in radarr, sonarr, prowlarr readarr and lidarr Apr 30, 2024
@onedr0p
Copy link
Owner Author

onedr0p commented May 13, 2024

Develop release for Prowlarr, Radarr, and Sonarr are all updated with new env and ability to disable the log database.

onedr0p/home-ops@8fa2830
onedr0p/home-ops@67607bf

@onedr0p
Copy link
Owner Author

onedr0p commented May 30, 2024

Env appears to be supported in Lidarr Lidarr/Lidarr@30d9891

Readarr still pending as of now Readarr/Readarr#3482

@sillock1
Copy link

sillock1 commented Jun 6, 2024

Env appears to be supported in Lidarr Lidarr/Lidarr@30d9891

Readarr still pending as of now Readarr/Readarr#3482

This should be in Readarr on the next develop release

@onedr0p
Copy link
Owner Author

onedr0p commented Jun 6, 2024

Lidarr changes are done. New builds will only accept officially supported ENV. Lidarr/Lidarr#4812

@onedr0p
Copy link
Owner Author

onedr0p commented Jun 6, 2024

Radarr changes are done. New builds will only accept officially supported ENV. Radarr/Radarr#9985

@onedr0p
Copy link
Owner Author

onedr0p commented Jun 6, 2024

Sonarr changes are done. New builds will only accept officially supported ENV. Sonarr/Sonarr#6746

@onedr0p
Copy link
Owner Author

onedr0p commented Jun 6, 2024

Prowlarr changes are done. New builds will only accept officially supported ENV. Prowlarr/Prowlarr@04bb0c5

@onedr0p onedr0p changed the title Deprecate envsubt methods in radarr, sonarr, prowlarr readarr and lidarr BREAKING: Switch to official env var support for radarr, sonarr, prowlarr readarr and lidarr Jun 7, 2024
@onedr0p
Copy link
Owner Author

onedr0p commented Jun 12, 2024

Readarr changes are done. New builds will only accept officially supported ENV. Readarr/Readarr#3482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants