Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report calculated entropies #558

Merged
merged 2 commits into from Apr 19, 2023
Merged

Report calculated entropies #558

merged 2 commits into from Apr 19, 2023

Conversation

e3krisztian
Copy link
Contributor

Extended existing code, so that entropy can be reported for outside use.

Refactor:

  • shuffled around code to do only one thing in entropy-calculation functions

Fixes:

  • typing for alternative imports from unblob.math
  • logging of entropy charts, which was unfortunately broken due to global state in the plotext library

unblob/processing.py Show resolved Hide resolved
unblob/math.py Show resolved Hide resolved
tests/test_processing.py Show resolved Hide resolved
Also fixed formatting of entropy plots: plotext library had kept some
state from previous plotted charts, which resulted in very uniform
output, not showing the real amount of percentages calculated.
@e3krisztian
Copy link
Contributor Author

Since the approval a test has been added for reporting entropy for unknown chunks and for files, that are not extracted further - except for empty files.
And also rebased to main.

@e3krisztian e3krisztian merged commit 373085b into main Apr 19, 2023
11 checks passed
@e3krisztian e3krisztian deleted the entropy branch April 19, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants