feat(processing): add multi-volume handler support #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e3krisztian
reviewed
Apr 24, 2023
qkaiser
reviewed
Apr 25, 2023
martonilles
force-pushed
the
multi-volume
branch
from
3ea7576
to
323eb81
Compare
|
Wait, since when do you develop in Rust ?? :) |
qkaiser
added
enhancement
e3krisztian
requested changes
May 3, 2023
martonilles
force-pushed
the
multi-volume
branch
2 times, most recently
from
c1ce53e
to
7b57d31
Compare
e3krisztian
requested changes
May 11, 2023
There was a problem hiding this comment.
It is ready to be merged, I have commented on some minor things, that would be better fixed now, than live with it (Extractable.extractable_id).
I would also like to get #579 merged first, to have an up to date type checker as soon as possible.
martonilles
force-pushed
the
multi-volume
branch
3 times, most recently
from
5e69bc9
to
3345e0d
Compare
|
The whole thing looks good ! I guess we could take advantage of these changes later on to allow users to provide a directory rather than a file as part of the command line by using a |
e3krisztian
force-pushed
the
multi-volume
branch
2 times, most recently
from
958a05e
to
97052dc
Compare
martonilles
changed the title
e3krisztian
reviewed
May 25, 2023
There are certain formats where the content is split between multiple files. Currently unblob operates under the assumption that all content resides in a single file. A few examples where this might be relevant: - multi-volume archives, such as 7zip, rar etc. - VM snapshots - content + index type formats This change introduces a DirectoryHandler which can operate on multiple files residing in one directory or at least under one subtree. Most formats there is a "main" file which can be identified by a directory file name pattern. Using this first file the handler can identify the other files and return a MultiFile object, similar to ValidChunks. We do not support cases where a single file is part of multiple MultiFile, also a file processed & extracted in the context of a MultiFile is not processed by traditional handlers. Also there is no carving step rather the files are extracted directly into an extraction directory. The original files are kept and never deleted, as these are normal files, unlike carved out temporary chunks. Files extracted from a MultiFile have a MultiFile as their parent. This required extending the current File -> Chunk reporting concept by introducing an abstract Blob type which is the parent of Chunk and MultiFile as well. MultiFileReports are reported under the directory Task, but contains all included file paths as well.
e3krisztian
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#553