Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_Something_ sometimes breaks the build script #1

Open
onelson opened this issue Jun 1, 2019 · 2 comments · Fixed by #2
Open

_Something_ sometimes breaks the build script #1

onelson opened this issue Jun 1, 2019 · 2 comments · Fixed by #2
Assignees

Comments

@onelson
Copy link
Owner

onelson commented Jun 1, 2019

Sometimes, and not all the time, alternating between a non-bundled build and a bundled build can break the build script (the C source tree appears to get partially cleaned up and not properly recreated?).

The tail end of the cargo output usually looks like:

gcc: error: src/lexer.c: No such file or directory
gcc: fatal error: no input files
compilation terminated.
make[2]: *** [src/lexer.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [install-recursive] Error 1
make: *** [install] Error 2
thread 'main' panicked at '
command did not execute successfully, got: exit code: 2

I'm still struggling to figure out how exactly to force this to happen.

@onelson onelson self-assigned this Jun 1, 2019
@onelson onelson changed the title Alternating between bundled and non-bundled sometimes breaks the build script _Something_ sometimes breaks the build script Jun 3, 2019
@onelson
Copy link
Owner Author

onelson commented Jun 3, 2019

Doesn't seem like switching features is required to trigger this. I just saw it happen after adding a new dev dependency. I'm still chasing ghosts here.

@onelson onelson transferred this issue from onelson/jq-sys Jun 9, 2019
onelson added a commit that referenced this issue Jun 9, 2019
Fixes #1. Run autotools build in thread to attempt recovery during failure.

Version bump, update issue cited for bug.

Let's do the version bump stuff in master, I guess.
onelson added a commit that referenced this issue Jun 9, 2019
Fixes #1. Run autotools build in thread to attempt recovery during failure.

Version bump, update issue cited for bug.

Let's do the version bump stuff in master, I guess.
@onelson onelson closed this as completed in #2 Jun 9, 2019
@onelson onelson reopened this Aug 1, 2019
@onelson
Copy link
Owner Author

onelson commented Aug 1, 2019

Just saw this in jq-rs's ci today. The paper patch I put over the hole isn't holding, and we need a more complete fix. I'm not sure what direction to turn in. I still suspect the best-case scenario would be to drop the dependency on the autotools crate, instead using the cc crate.

When I looked into switching to cc, I ran into a bunch of deadends with no clear solutions, but maybe I'm smarter than I was before.

Other solutions might be to watch filesystem changes while a build is in progress to try and figure out why certain files are reported as missing when they really shouldn't be. I don't know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant