Got JS for replace XBL tabmixbindings working! #3

117649 · 2020-12-31T14:28:32Z

This one is easier then I expect. Now the protect, locked and auto reload icon on tab is showing if you toggle the preference on and off and apply the changes to let the tab box got settings updated.

…t complete)

117649 · 2020-12-31T19:24:46Z

protected, locked and auto reload icon on tab is showing now.

117649 · 2021-01-04T02:02:30Z

I don't find any code that trigger the loading of dynamic styles. I can only apply the style by change prefs. Just wonder how this is done on old firefox @onemen .

onemen · 2021-01-07T06:19:36Z

I don't find any code that trigger the loading of dynamic styles. I can only apply the style by change prefs. Just wonder how this is done on old firefox @onemen .

It is a little bit convoluted.

Most of dynamic style are triggers from modules/DynamicRules.jsm look below for the sequence that trigger it when ever new window is open.

setup.js

Tabmix.beforeBrowserInitOnLoad = function() {
  try {
    TabmixSvc.windowStartup.init(window);
  } catch (ex) {
    this.assert(ex);
  }

TabmixSvc.jsm

this.TabmixSvc = {
  ...
  windowStartup: {
      ...
      Cu.import("resource://tabmixplus/DynamicRules.jsm", tmp);
      tmp.DynamicRules.init(aWindow);
      ...    
  }
  ...
}

Some other rule can be found by searching for all the calls for gTMPprefObserver.insertRule or this.insertRule

117649 · 2021-01-10T14:13:39Z

It looks like there is a problem with the progress bar on tab. The bar just can't get progress accurately only very small amount of pages can have their progress displayed others just have their aCurTotalProgress equals aMaxTotalProgress while the listener first ever been triggered.

onemen · 2021-01-10T17:40:41Z

It looks like there is a problem with the progress bar on tab. The bar just can't get progress accurately only very small amount of pages can have their progress displayed others just have their aCurTotalProgress equals aMaxTotalProgress while the listener first ever been triggered.

it is better to drop this feature

117649 · 2021-01-10T18:25:11Z

It looks like there is a problem with the progress bar on tab. The bar just can't get progress accurately only very small amount of pages can have their progress displayed others just have their aCurTotalProgress equals aMaxTotalProgress while the listener first ever been triggered.

it is better to drop this feature

Not necessary to drop it.
Even web extension add-on can provide basically same function. There is work around to be use.

onemen · 2021-01-11T19:54:32Z

Please don't upload the file - tab_mix_plus-0.5.8.1-fx-p.xpi into the pull request.
can you i would like to add all your changes without the commits "Add files via upload".

Maybe I just squash all the the pull request into one commit

117649 · 2021-01-12T07:24:17Z

I've added .gitignore
and for the progress bar on tab something like this:

let observer = new MutationObserver((mutations) => {
        mutations.forEach((mutation) => {
            mutation.addedNodes.forEach((node) => {
                if (node.nodeName == "BODY") {
                    inserted++;
                    node.addEventListener( "load", () => onLoadHandler(node), listenerCfg);
                    updateProgress();
                } else if (((node.nodeName == "SCRIPT" ||
                            node.nodeName == "VIDEO"  || node.nodeName == "IMG"    ||
                            node.nodeName == "IFRAME" || node.nodeName == "FRAME") && node.src != "" ) ||
                            (node.nodeName == "LINK" && node.rel == "stylesheet" && window.matchMedia(node.media))
                ) {
                    inserted++;
                    node.addEventListener( "error",   () => onLoadHandler(node), listenerCfg);
                    node.addEventListener( "abort",   () => onLoadHandler(node), listenerCfg);
                    node.addEventListener( "load",    () => onLoadHandler(node), listenerCfg);
                    updateProgress();
                }
            });
        });
    });

~~Would do the trick but I'm yet to find the way to insert it in to the content document.~~
Looks like I could just put this in content.js and have it send out messages.

onemen · 2021-01-13T05:55:11Z

What will happen when a user with 100+ tabs loads all the tabs at startup ?

117649 · 2021-01-13T06:30:20Z

What will happen when a user with 100+ tabs loads all the tabs at startup ?

I'm not yet have any success with the content.js the code is not as responsive as the web extension I'm still figuring out why.

onemen · 2021-01-13T18:26:44Z

I'm currently working on merging your PR with my local repository, while applying lint rules.

I hope to push it to GitHub this week.

onemen · 2021-01-13T18:43:09Z

chrome/content/Overlays.jsm

+			container: aWindow.document.createElement('box')
+		};
+
+		setAttribute(node.tempAppend.container, 'style', 'position: fixed; top: 4000px; left: 4000px; opacity: 0.001;');


'setAttribute' is not defined ?

Is this one complain an error on you environment?

onemen · 2021-01-13T18:57:26Z

chrome/content/Overlays.jsm

+
+			data.onBuild = function(aDocument, aDestroy) {
+				// Find the node in the DOM tree
+				var node = aDocument.getElementById(this.id);


'node' used outside of binding context.eslintblock-scoped-var
'node' is already declared in the upper scope.eslintno-shadow

node is argument of getWidgetData, use different var name here

onemen · 2021-01-13T18:59:45Z

chrome/content/Overlays.jsm

+				// If it doesn't exist there either, CustomizableUI is using the widget information before it has been overlayed (i.e. opening a new window).
+				// We get a placeholder for it, then we'll replace it later when the window overlays.
+				if(!node && !aDestroy) {
+					var node = aDocument.importNode(Globals.widgets[this.id], true);


same as above, it is also unclear if you want the node you declare here be the one that return by line 832

Well this whole block of code is actually chopped and pasted here from the Tab-group add-on for handle the toolbarbutton rightly. I didn't change any bit of it so it is sure to look quite weird.
But as long as I can tell they are working fine and not complain.

chrome/content/preferences/prefs-ce.js

onemen · 2021-01-14T15:46:11Z

Thank you @117649

I've just uploaded Tab mix complete history with your code merge to it.
You can close this PR #3 and #1.

I would appreciate if you can add a follow-up to PR #3 (in new PR) for the following:

remove commented code
remove non English comment
remove unused files that already replaced by Got JS for replace XBL tabmixbindings working! #3
- xul files that replaced by xhtml files
- xml files that replaced by jsm files, or js files (by the way what is CE stand for?)
- css files ?
- chrome.manifest - i don't know if this file still in use

For future patches pleas open an issue for each feature you are trying to fix and push the code for each issue to a separate pull request.
Make all pull request code to rewrite/main.

My Todo:

Use Prettier and Eslint to reformat all files (eslint recommended, prettier recommended).
Work on rewriting function calls that uses eval (there are 146), to modify Firefox code.
Rewrite options dialog to use in tab options like Firefox.
Remove obsolete code (code for compatibility with older versions of Firefox and/or Pale moon)

Let me know if there are any issue that you think I should prioritize

Since this rewrite is going to take a long time I think we should focus on makeing Tab mix compatible with latest Firefox Nightly and the next Firefox ESR. If compatibility with Waterfox will be straightforward we add it as well

117649 · 2021-01-14T18:24:47Z

remove non English comment

The only one I know is in the prefs-ce.js don't know who created it but I'm sure it is converted from the old xbl bindings so the comment should just be the translation from the original I hope.

(by the way what is CE stand for?)

Custom Elements
I used this alias a lot because I copied prefs-ce.js from elsewhere and decided not to change the naming style, by no means this alias is formal.

chrome.manifest - i don't know if this file still in use

Yes they are used and almost function just like old time.
Except the 'overlay' and 'resource' instructions are powerless now.
Set 'overlay' in the bootstrap.js and replace 'resource' with 'content'.

So now there is only bootstrap way for legacy add-ons which means all things load and execute at a later time I already have to adjust the execute order of some code to get the tab appearance functions work.

For the Firefox versions compatibility it is a little bizarre situation here:

For the latest Waterfox G3 which is based on Firefox 78ESR the compatibility should just be straightforward.
You need a helper to load the bootstrap legacy add-on, Waterfox already came with one.
The helper came in two types extension and script. I would consider the one waterfox provided is script type.
The two types of the helper CAN co-exist BUT SHOULD NOT since this will cause two helper in the browser and load every bootstrap legacy add-on twice. Which will cause problem.

I hope you keep the preferences intact at least for the those related to tab appearances. Tab-group compatibility for Tabmix still lives don't want that to be ruined.
And I hope the progress bar on tab is kept they are such mentally comfortable to see. The 'onProgressChange' listener is not given right progress number every time now but 'onStateChange' is still good at least a pseudo progress is acceptable.

117649 added 30 commits November 27, 2020 18:10

Add files via upload

bb00023

1st stage only loadable

f6d3ebb

Update prefs-ce.js

f1d0c65

Update tab_mix_plus-0.5.8.1-fx-p.xpi

d98b824

Update bootstrap.js

879be87

Add files via upload

eb70130

fixe shortcut ce

93c6810

Add files via upload

bcfa4b2

mTabstrip -> arrowScrollbox

f4812a2

Add files via upload

592c72f

mPanelContainer -> tabpanels boxObject -> getBoundingClientRect() (no…

56c7cec

…t complete)

Update tab_mix_plus-0.5.8.1-fx-p.xpi

c83f319

Add files via upload

75f4a53

prefpan tabs should be load properly

1ca1931

Add files via upload

87a9c89

more fix on option dialog

d494cac

keep fixing option window

8ebff69

textbox -> html:input & RDFDataSource.jsm added

716d608

Update tab_mix_plus-0.5.8.1-fx-p.xpi

19ef6f5

Add files via upload

96947d8

fixing sub dial

dccad21

Add files via upload

e3e8807

subdialog fixing

72f026a

subdialog fixing

fc0c44f

Add files via upload

2571954

preference fixes

4f12014

hack about:addon fixed

202b753

Add files via upload

8dd5b40

aboutaddon right way

b1587b2

Add files via upload

3ab4bca

117649 added 4 commits January 1, 2021 14:29

small fixs

3ff6020

load order fix

849858a

trying to get tab appearance working

8c8ad22

trying to fix style for tab appearance

9a02580

117649 added 2 commits January 5, 2021 03:15

little things

d8fac27

little things

4576903

117649 added 3 commits January 8, 2021 19:13

so dynamic style is working

ffe29dd

tweaking with progress bar on tab

9f44d3d

progress on tab should show at some time now

b9641ba

117649 added 2 commits January 12, 2021 10:01

Create .gitignore

5d457bf

Delete tab_mix_plus-0.5.8.1-fx-p.xpi

302970c

onemen reviewed Jan 13, 2021

View reviewed changes

chrome/content/preferences/prefs-ce.js Show resolved Hide resolved

117649 closed this Jan 14, 2021

onemen mentioned this pull request Jan 15, 2021

How to use helper loader #5

Closed

Bearmancer mentioned this pull request Sep 19, 2021

Questions regarding TMP settings #77

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Got JS for replace XBL tabmixbindings working! #3

Got JS for replace XBL tabmixbindings working! #3

117649 commented Dec 31, 2020

117649 commented Dec 31, 2020

117649 commented Jan 4, 2021

onemen commented Jan 7, 2021

117649 commented Jan 10, 2021

onemen commented Jan 10, 2021

117649 commented Jan 10, 2021

onemen commented Jan 11, 2021

117649 commented Jan 12, 2021 •

edited

Loading

onemen commented Jan 13, 2021

117649 commented Jan 13, 2021 •

edited

Loading

onemen commented Jan 13, 2021

onemen Jan 13, 2021

117649 Jan 14, 2021

onemen Jan 13, 2021

onemen Jan 13, 2021

117649 Jan 14, 2021

onemen commented Jan 14, 2021

117649 commented Jan 14, 2021 •

edited

Loading

Got JS for replace XBL tabmixbindings working! #3

Got JS for replace XBL tabmixbindings working! #3

Conversation

117649 commented Dec 31, 2020

117649 commented Dec 31, 2020

117649 commented Jan 4, 2021

onemen commented Jan 7, 2021

117649 commented Jan 10, 2021

onemen commented Jan 10, 2021

117649 commented Jan 10, 2021

onemen commented Jan 11, 2021

117649 commented Jan 12, 2021 • edited Loading

onemen commented Jan 13, 2021

117649 commented Jan 13, 2021 • edited Loading

onemen commented Jan 13, 2021

onemen Jan 13, 2021

Choose a reason for hiding this comment

117649 Jan 14, 2021

Choose a reason for hiding this comment

onemen Jan 13, 2021

Choose a reason for hiding this comment

onemen Jan 13, 2021

Choose a reason for hiding this comment

117649 Jan 14, 2021

Choose a reason for hiding this comment

onemen commented Jan 14, 2021

My Todo:

117649 commented Jan 14, 2021 • edited Loading

117649 commented Jan 12, 2021 •

edited

Loading

117649 commented Jan 13, 2021 •

edited

Loading

117649 commented Jan 14, 2021 •

edited

Loading