Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code clean up #7

Merged
merged 2 commits into from
Jan 19, 2021
Merged

code clean up #7

merged 2 commits into from
Jan 19, 2021

Conversation

117649
Copy link
Contributor

@117649 117649 commented Jan 15, 2021

I hope this time it is right.

@onemen
Copy link
Owner

onemen commented Jan 15, 2021

It doesn't look right to me, the PR should contain only your last commit (6d4c930)
this is the only change you made since you last pull

@117649
Copy link
Contributor Author

117649 commented Jan 15, 2021 •
edited
Loading

Now nailed it.

@117649 117649 mentioned this pull request Jan 17, 2021
Closed
onemen
onemen requested changes Jan 19, 2021
View reviewed changes
Copy link
Owner

@onemen onemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, just some minor changes

  • Replace 171f705 with commit that address the fix according to my comment.
  • Move styles changes from: 779ab82, cc5f2b3 to separate PR

addon/chrome/content/preferences/prefs-ce.js Show resolved Hide resolved
@117649 117649 force-pushed the main branch 2 times, most recently from 0acc7e5 to 5ba0de4 Compare January 19, 2021 10:19
@onemen onemen merged commit 4fc5f0c into onemen:rewrite/main Jan 19, 2021
@Bearmancer Bearmancer mentioned this pull request Sep 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onemen onemen onemen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@117649 @onemen