Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: minikube installation instructions #59

Merged
merged 2 commits into from Aug 24, 2020
Merged

feat: minikube installation instructions #59

merged 2 commits into from Aug 24, 2020

Conversation

Vafilor
Copy link
Contributor

@Vafilor Vafilor commented Aug 20, 2020 •
edited

What this PR does:

  • Adds a macOS tab for starting minikube
  • Adds metallb flag to the minikube init command since it is required anyway

Which issue(s) this PR fixes:

Fixes onepanelio/core#

Special notes for your reviewer:

@Vafilor
update: mac tab for installing minikube and have metallb in the defau…
10ba8ae 
…lt statement with a note indicating why it's there.
@Vafilor Vafilor added this to the v0.12.0 milestone Aug 20, 2020
@Vafilor Vafilor added the kind/docs Improvements or additions to documentation label Aug 20, 2020
@Vafilor Vafilor self-assigned this Aug 20, 2020
@Vafilor Vafilor changed the title update: minikube installation instructions feat: minikube installation instructions Aug 20, 2020
@rushtehrani
Copy link
Contributor

@Vafilor can you fix conflicts?

@rushtehrani rushtehrani merged commit 216937e into dev Aug 24, 2020
@rushtehrani rushtehrani deleted the feat/minikube.updates branch August 24, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rushtehrani rushtehrani Awaiting requested review from rushtehrani

Assignees

@Vafilor Vafilor

Labels
kind/docs Improvements or additions to documentation
Projects
None yet
Milestone
v0.12.0
2 participants
@Vafilor @rushtehrani