Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing edit labels button in workflow execution #139

Merged
merged 1 commit into from Jul 13, 2020

Conversation

Vafilor
Copy link
Contributor

@Vafilor Vafilor commented Jul 13, 2020

What this PR does:

Fixes an issue where edit labels button did not show up in workflow executions.
This was due to a missing update permissions request.
This also fixes an issue where the permissions request were for workspaces and not workflows.

Which issue(s) this PR fixes:

Fixes onepanelio/onepanel#403

Special notes for your reviewer:

@Vafilor Vafilor requested a review from rushtehrani July 13, 2020 21:58
@rushtehrani rushtehrani merged commit 2d0413c into dev Jul 13, 2020
@rushtehrani rushtehrani deleted the fix/onepanelio.core-403.missing.edit.labels branch July 13, 2020 22:10
@rushtehrani rushtehrani added this to the v0.12.0 milestone Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants