fix: Add migration for changes in TFOD and CVAT template #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rushtehrani
reviewed
Nov 30, 2020
db/data/20201130130725_cvat.yaml
Outdated
| mountPath: /etc/onepanel | ||
| readOnly: true | ||
| - name: cvat-ui | ||
| image: onepanel/cvat-ui:0.14.0_cvat.1.0.0 |
There was a problem hiding this comment.
This doesn't look like the latest template
|
The migrations also need to be added to db/go/db.go |
rushtehrani
changed the title
|
Can you update the TFOD template based on the last migration template? It'll make it easier to diff. |
|
@rushtehrani can you check now? |
rushtehrani
reviewed
Nov 30, 2020
|
|
||
| //Down20201130130433 do nothing | ||
| func Down20201130130433(tx *sql.Tx) error { | ||
| // This code is executed when the migration is rolled back. |
There was a problem hiding this comment.
This should update to the previous template:
return updateWorkflowTemplateManifest(
"20201115134934_tfod.yaml",
tfodWorkflowTemplateName,
map[string]string{
"used-by": "cvat",
},
)
There was a problem hiding this comment.
Just to confirm, inside Down20201130130433?
There was a problem hiding this comment.
yes, only in down migration. Looks like you changed up migration to use the old template too?
rushtehrani
reviewed
Nov 30, 2020
| func Up20201130130433(tx *sql.Tx) error { | ||
| // This code is executed when the migration is applied. | ||
| return updateWorkflowTemplateManifest( | ||
| "20201115134934_tfod.yaml", |
There was a problem hiding this comment.
This looks incorrect now, should be: 20201130130433_tfod.yaml
There was a problem hiding this comment.
yeah, updating now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes onepanelio/core#
Special notes for your reviewer:
Checklist
Please check if applies
Required