Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Move env vars to workspace creation #757

Merged
merged 3 commits into from
Dec 4, 2020
Merged

fix: Move env vars to workspace creation #757

merged 3 commits into from
Dec 4, 2020

Conversation

rushtehrani
Copy link
Contributor

@rushtehrani rushtehrani commented Dec 2, 2020 •
edited
Loading

What this PR does:

Which issue(s) this PR fixes:

Fixes onepanelio/core#

Special notes for your reviewer:

Checklist

Please check if applies

  • I have added/updated relevant unit tests
  • I have added/updated relevant documentation

Required

  • I accept to release these changes under the Apache 2.0 License

@rushtehrani rushtehrani changed the title wip - move env vars to workspace creation fix: Move env vars to workspace creation Dec 4, 2020
@rushtehrani rushtehrani added this to the v0.16.0 milestone Dec 4, 2020
@rushtehrani rushtehrani marked this pull request as ready for review December 4, 2020 20:56
@Vafilor Vafilor merged commit a85f972 into master Dec 4, 2020
@Vafilor Vafilor deleted the fix/dynamic-envs branch December 4, 2020 20:58
@rushtehrani rushtehrani linked an issue Dec 4, 2020 that may be closed by this pull request
Changing fqdn / domain in params.yaml does not automatically update existing workspace templates . #753
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.

Changing fqdn / domain in params.yaml does not automatically update existing workspace templates .
2 participants
@rushtehrani @Vafilor