Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: envoy filter checks ignore auth header, if present #76

Merged
merged 1 commit into from Jul 16, 2020
Merged

fix: envoy filter checks ignore auth header, if present #76

merged 1 commit into from Jul 16, 2020

Conversation

Vafilor
Copy link
Contributor

@Vafilor Vafilor commented Jul 15, 2020

What this PR does:

Updates the envoy filter to check for an Authorization header in the incoming request, and if present, adds it to the request.
Otherwise, if there is no auth header, it uses the cookie, if present.

Which issue(s) this PR fixes:

Fixes onepanelio/onepanel#413

Special notes for your reviewer:

@Vafilor
fix: envoy filter uses authorization header if present. Otherwise use…
a7fc63f 
…s cookie, if present.

Before it went straight to cookie, ignoring any auth header
@aleksandrmelnikov aleksandrmelnikov merged commit b06fb55 into dev Jul 16, 2020
@aleksandrmelnikov aleksandrmelnikov deleted the fix/onepanelio.core.413-envoy.auth.header branch July 16, 2020 17:20
aleksandrmelnikov pushed a commit that referenced this pull request Jul 17, 2020
Revert "Merge pull request #76 from onepanelio/fix/onepanelio.core.41…
48a87fb 
…3-envoy.auth.header"

This reverts commit b06fb55, reversing
changes made to f85d4fa.
@rushtehrani rushtehrani added this to the v0.12.0 milestone Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksandrmelnikov aleksandrmelnikov aleksandrmelnikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.12.0
3 participants
@Vafilor @aleksandrmelnikov @rushtehrani