feat: Add node pool parameter #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… This will perform any modifications needed to replace types with runtime data, etc. An example is select.nodepool. This value should set the options to the currently available node types.
…logic to replace select.nodepool values with runtime values.
rushtehrani
reviewed
Dec 24, 2020
db/yaml/maskrcnn/20201221195937.yaml
Outdated
| ports: | ||
| - containerPort: 6006 | ||
| name: tensorboard | ||
| sidecars: |
There was a problem hiding this comment.
This indentation seems incorrect - it should line up with nodeSelector
rushtehrani
reviewed
Dec 24, 2020
db/yaml/maskrcnn/20201221195937.yaml
Outdated
| @@ -11,13 +11,13 @@ arguments: | |||
| value: annotation-dump/sample_dataset | |||
There was a problem hiding this comment.
Bit confused about this file, are you deleting an old migration file here?
There was a problem hiding this comment.
@rushtehrani This migration adds the select.nodepool parameter
rushtehrani
reviewed
Dec 24, 2020
db/yaml/tfod/README.md
Outdated
| @@ -0,0 +1 @@ | |||
| https://github.com/onepanelio/templates/blob/master/workflows/maskrcnn-training/template.yaml | |||
There was a problem hiding this comment.
don't think we need this README here
…match onepanel templates repo
…sources for migrations. Also updated migration yamls to the latest based on templates repo.
|
@Vafilor can you address the conflict? |
… This will perform any modifications needed to replace types with runtime data, etc. An example is select.nodepool. This value should set the options to the currently available node types.
…logic to replace select.nodepool values with runtime values.
…match onepanel templates repo
…sources for migrations. Also updated migration yamls to the latest based on templates repo.
@rushtehrani Sure thing - should be good. |
rushtehrani
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes onepanelio/core#
Special notes for your reviewer:
Checklist
Please check if applies
Required