Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve markdown list handling #244

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

shiftinv
Copy link
Contributor

@shiftinv shiftinv commented Apr 7, 2023

Fixes https://canary.discord.com/channels/755868545279328417/1093642705759899678, rewriting/fixing the (still fairly simple) codeblock detection in the process.

The first commit is a revert, the diff becomes much more readable by skipping it.

@onerandomusername
Copy link
Owner

deferring to when new markdown is released by Discord.

@shiftinv shiftinv marked this pull request as draft May 4, 2023 13:08
@onerandomusername
Copy link
Owner

deferring to when new markdown is released by Discord.

given they released it an unreleased it, i'll be adding this as part of a configuration option internally with both old and new styles

@onerandomusername
Copy link
Owner

@shiftinv would you please update this pr to follow the logic in 797738b

when constants.DiscordFeatures.extended_markdown is true, then we should use discord's new markdown implementation
if that's false, we should use a simplified markdown implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants