feat(github): support <repo>/discussions/<id> links, expanding discussions
#265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiftinv
changed the title
<repo>/discussions/<id> links<repo>/discussions/<id> links, expanding discussions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
|discussionsto the url regex, and slightly refactors the handling infetch_issuesto save an unnecessary REST call if we already know it won't succeed.Additionally adds all the required fields to the GQL query to support expanding discussions, like issues/PRs.
That being said,
/issues/<discussion_id>still works as before and links the discussion with that ID, despite the url being/issues/. This currently does a REST + GQL call.It would be trivial to change this to only do the REST call, dropping support for linking discussions via the
/issues/url. GitHub itself correctly redirects these links to/discussions/, so I'm not sure if dropping support would be a good idea.