Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saving a setting with the existing value errors #45

Closed
lfkeitel opened this issue Dec 23, 2016 · 0 comments
Closed

Saving a setting with the existing value errors #45

lfkeitel opened this issue Dec 23, 2016 · 0 comments
Labels
bug

Comments

@lfkeitel
Copy link
Member

Steps to reproduce: Go to Settings -> click Save without changing anything. An error is returned. It should return a success.
@lfkeitel lfkeitel added the bug label Dec 23, 2016
lfkeitel added a commit that referenced this issue Jan 22, 2017
@lfkeitel
Fixes #45 - Don't error when saving setting with same value
4845b7f 
The database class was returning 0, a falsy value, since no rows
were being updated. This caused the system to think a failure had
occured. UserSettings now checks if the setting already has the
desired value and doesn't perform an update if it is.

Also changed PDO to error mode Exception and added and internal
message to APIException. Existing APIException usages will continue
working as usual. If an internal message is given, it will returned.
Otherwise the "normal" message will be returned.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lfkeitel