Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dates disabling/restriction props #30

Merged
merged 12 commits into from Jan 9, 2023

Conversation

NoahMLoomis
Copy link
Contributor

Props added:

  • minDate: The minimum date that can be selected (inlcusive)
  • maxDate: The maximum date that can be selected (inlcusive)
  • disabledDates: An array of date ranges to be disabled

I think having separate props for minData/maxDate and disabledDates improves clarity.

@onesine How can I update the Documentation site?

Also @JefteCaro thanks for creating the playground, it made the DX 10X better

@onesine
Copy link
Owner

onesine commented Jan 6, 2023

Props added:

  • minDate: The minimum date that can be selected (inlcusive)
  • maxDate: The maximum date that can be selected (inlcusive)
  • disabledDates: An array of date ranges to be disabled

I think having separate props for minData/maxDate and disabledDates improves clarity.

@onesine How can I update the Documentation site?

Also @JefteCaro thanks for creating the playground, it made the DX 10X better

It also offers more possibilities. We can even combine everything.

@onesine onesine self-requested a review January 6, 2023 22:16
Copy link
Owner

@onesine onesine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make these changes?

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@onesine onesine requested review from onesine and JefteCaro and removed request for onesine January 6, 2023 23:26
package.json Outdated Show resolved Hide resolved
Copy link
Contributor Author

@NoahMLoomis NoahMLoomis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed bad package name and version number

Copy link
Contributor Author

@NoahMLoomis NoahMLoomis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished self-review

@onesine
Copy link
Owner

onesine commented Jan 9, 2023

Thanks @NoahMLoomis for this PR

@JefteCaro JefteCaro requested a review from onesine January 9, 2023 13:30
@onesine
Copy link
Owner

onesine commented Jan 9, 2023

Merge won't happen if we don't resolve the conflicts

@JefteCaro
Copy link
Collaborator

@onesine Yeah

@NoahMLoomis
Thank you for the fix.
Can I ask to have the yarn.lock be removed from .gitignore in the mean time, so the yarn.lock file can be added to your commits?

@onesine
Copy link
Owner

onesine commented Jan 9, 2023

Yes, in fact, I'm working on it right now.

@onesine
Copy link
Owner

onesine commented Jan 9, 2023

I think it should be good now.

@JefteCaro JefteCaro merged commit faf885f into onesine:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Disable or otherwise manipulate specific days
3 participants