Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add frontend editing mixin #302

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from
Open

Add frontend editing mixin #302

wants to merge 18 commits into from

Conversation

AidanCurrah
Copy link
Contributor

@AidanCurrah AidanCurrah commented Dec 17, 2018 •
edited
Loading

Still needs:

  • JS code cleanup
  • Associated CMS small changes
  • Allow users to view media library from HTMLField image selector
  • Some styles/make it look good
  • Edit mode toggle
  • Un-hardcode post and get URLs
  • Handle max_length of CharFields

lewiscollard
lewiscollard reviewed Dec 17, 2018
View reviewed changes
{{cookiecutter.repo_name}}/{{cookiecutter.package_name}}/assets/js/frontend-editing/wysiwyg.js
@@ -0,0 +1,95 @@
import tinymce from 'tinymce/tinymce'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is probably a better answer than having a second copy of TinyMCE running on the frontend - we should be able to change TinyMCE settings in a single place (settings/base.py) rather than two.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(The other option is that we have an extremely pared-down version of MCE for small edits - in which case, you can remove most of the plugins that have been loaded.)

lewiscollard
lewiscollard reviewed Dec 18, 2018
View reviewed changes
{{cookiecutter.repo_name}}/{{cookiecutter.package_name}}/assets/js/frontend-editing/editable.js
model: this.el.dataset.model,
pk: this.el.dataset.pk,
field: this.el.dataset.field,
value: this.el.innerHTML
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

innerText might be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewiscollard lewiscollard lewiscollard requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AidanCurrah @lewiscollard @daniel-clayton