Store the Cell containing ARGV instead of the ARGV table itself. #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@millert Can you please add a regression test to the test suite? Thanks! |
millert
force-pushed
the
ARGV_use_after_free
branch
from
768b5d3
to
1ced796
Compare
|
@arnoldrobbins I added a test to testdir/T.argv that crashes on Linux (or OpenBSD) without the fix. |
|
thanks todd. |
|
And I will also |
mpinjr
reviewed
May 4, 2024
The underlying table (array) may change due to, for example, "delete ARGV". However, the Cell that stores ARGV should not change. Also remove the ENVtab global which is never used outside of envinit(). Fixes issue onetrueawk#229.
millert
force-pushed
the
ARGV_use_after_free
branch
from
1ced796
to
d11b2d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying table (array) may change due to, for example, "delete ARGV". However, the Cell that stores ARGV should not change. Also remove the ENVtab global which is never used outside of envinit(). Fixes issue #229.