Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable Disk cache TTL extending #1286

Closed
makesource opened this issue Sep 19, 2019 · 2 comments
Closed

Add option to disable Disk cache TTL extending #1286

makesource opened this issue Sep 19, 2019 · 2 comments

Comments

@makesource
Copy link
Contributor

Issue Description

What

Maybe related with #1196.
But I wonder why not support this option in DiskCache.
I use both MemoryCache and DiskCache to optimize image load and works well in most of cases.
But when the image corresponds to static URL changed, Kingfisher never refresh cached image until extended expired date (which updated every cache hit).
If the image frequently accessed, this expire date extends without limitation.
So that's why I need to control cache extend option in DiskCache.

If there's not similiar discussion on this topic, could I write a new PR on this?

@onevcat
Copy link
Owner

onevcat commented Sep 20, 2019

Yes, I agree that we can add the same feature for the disk cache. Can you please create a PR for that? Thanks!

@makesource
Copy link
Contributor Author

resolve in PR #1287.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants