Add options regarding disk cache TTL extending #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hard to set up DiskCache Tests because |
|
No worry! I will check the test things. |
|
LGTM! |
|
Your code is great. Thank you for your contribution! |
|
Related #1152 |
2 tasks
skoduricg
pushed a commit
to rentpath/Kingfisher
that referenced
this pull request
Sep 24, 2021
…ache-ttl-extending-options Add options regarding disk cache TTL extending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1286,
This PR is for diskCache TTL extending strategy.
Use case
If you use diskCache option, you may want to control disk Cache expiration date.
But It is hard to control the expiration because of the TTL extending.
(In worst case, the image will never expired if frequently accessed)
So in this PR, I want to get some more accurate control of cache by offering diskCache expirationExtending options. (like memorycache extending option in #1196)
Feel free to give any suggestions and thoughts :)
Thanks.