Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting a duplicate code error when trying to add Kingfisher 5.15.1 via Xcode 12 GM SPM #1512

Closed
ethanwa opened this issue Sep 16, 2020 · 3 comments

Comments

@ethanwa
Copy link

ethanwa commented Sep 16, 2020

Screen Shot 2020-09-16 at 12 14 33 PM

Any ideas what the issue may be here? 'collectors' is my project target and name.

@mpdifran
Copy link

SPM in Xcode only produces static libraries. If you want to include Kingfisher in multiple targets, you won't be able to use SPM at the moment. My guess for your setup is just link to KingfisherDynamic instead of Kingfisher.

@onevcat
Copy link
Owner

onevcat commented Sep 17, 2020

Due to a previous bug of Xcode, Kingfisher defined multiple libraries, including automatic (static) and explicit dynamic ones. Currently that bug was already fixed and there should be no need to separate them. But I choose to keep these targets for a while for back compatibility. If there is no good reason, please ensure you just link the standard one “Kingfisher” to your target, and remove any other ones (“KingfisherDynamic” for example) from your link library phase.

@ethanwa
Copy link
Author

ethanwa commented Sep 18, 2020

Setting it to just “Kingfisher” seems to have solved the issue. Thank you.

@onevcat onevcat closed this as completed Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants