Avoid racing for accessing originalRequest #1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds/adjusts some lock behaviors. This should help to avoid racing for accessing originalRequest properties and fix #1511
3 tasks
| @@ -92,22 +99,22 @@ class SessionDelegate: NSObject { | |||
| } | |||
|
|
|||
| private func remove(_ task: URLSessionTask) { | |||
| lock.lock() | |||
| defer { lock.unlock() } | |||
|
|
|||
| guard let url = task.originalRequest?.url else { | |||
There was a problem hiding this comment.
Wouldn't you want to use task.originalURL here as well? Also in task(for:), so we only ever call task.originalRequest?.url once, and that's in the SessionDataTask init. Then I don't think you need to adjust the locks (or at least I don't think it will affect the behavior)
danielbyon-hulu
approved these changes
Oct 28, 2020
skoduricg
pushed a commit
to rentpath/Kingfisher
that referenced
this pull request
Sep 24, 2021
Avoid racing for accessing originalRequest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds/adjusts some lock behaviors. This should help to avoid racing for accessing originalRequest properties and fix #1511