Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UCL-324 Tabs uses Quantum stylings and behaviour #634

Merged
merged 5 commits into from
Oct 5, 2023

Conversation

pawel-napieracz
Copy link
Contributor

No description provided.

@pawel-napieracz pawel-napieracz requested a review from a team as a code owner September 22, 2023 09:39
@pawel-napieracz
Copy link
Contributor Author

I changed buttonBorderRadius so maybe that's why there are so many changes to so many stories ;)

@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.3% 85.3% Coverage
0.0% 0.0% Duplication

src/components/Tabs/TabButton.tsx Show resolved Hide resolved
src/components/Tabs/Tab.tsx Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icons are not horizontally aligned with the labels

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

align-items: center; is set. You can check it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧔‍♂️, I still see that those are aligned

src/components/Tabs/Tab.tsx Show resolved Hide resolved
@MichalGorskiOnegini MichalGorskiOnegini merged commit ef88227 into master Oct 5, 2023
11 of 12 checks passed
@MichalGorskiOnegini MichalGorskiOnegini deleted the UCL-324 branch October 5, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants