CUI-156 Add new admin components directory with microfrontend container #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawel-napieracz
previously approved these changes
May 13, 2024
stories/admin/MicrofrontendContainer/MicrofrontendContainer.mdx
Outdated
Show resolved
Hide resolved
|
|
||
| The component is based on the following design: [LINK](https://www.figma.com/file/tZLMF6dw6LOSkmEhlV3rkF/UI-Patterns?type=design&node-id=2107%3A16959&mode=design&t=9UWjpVqhIeYZOXXR-1) | ||
|
|
||
| # Props |
There was a problem hiding this comment.
I'd see example usage here ;P. WDYT? Worth to add?
There was a problem hiding this comment.
it's quite specific so IMO it's sufficient how it is
| /* | ||
| * FIXME: This component is meant to be moved to a separate UCL package when it's finished. | ||
| */ | ||
| export const MicrofrontendContainer: ForwardRefRenderFunction<HTMLDivElement, Props> = ({ |
There was a problem hiding this comment.
Make it experimental, as it may change when a new form component is ready.
|
|
After discussing with @pawel-napieracz we decided it will be handled correctly in a separate ticket: https://onewelcome.atlassian.net/browse/UCL-478 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.