Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove storage deltas map reset #165

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Remove storage deltas map reset #165

merged 1 commit into from
Oct 8, 2021

Conversation

fxamacker
Copy link
Member

Closes #164

Description

Do NOT reset deltas map in storage during Commit() because
slabs with empty address are not saved.

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@fxamacker
Remove storage deltas map reset
d7392b5 
Do NOT reset deltas map in storage during Commit() because
slabs with empty address are not saved.
@fxamacker fxamacker added the bug Something isn't working label Oct 8, 2021
@fxamacker fxamacker self-assigned this Oct 8, 2021
@fxamacker fxamacker merged commit 6f37862 into main Oct 8, 2021
@fxamacker fxamacker mentioned this pull request Oct 8, 2021
Closed
@fxamacker fxamacker deleted the fxamacker/remove-delta-reset branch October 21, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramtinms ramtinms ramtinms approved these changes

@turbolent turbolent Awaiting requested review from turbolent turbolent is a code owner

Assignees

@fxamacker fxamacker

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deltas map reset during Commit
2 participants
@fxamacker @ramtinms