New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add static type to host functions #1144
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1144 +/- ##
==========================================
+ Coverage 73.33% 73.35% +0.01%
==========================================
Files 272 272
Lines 34572 34586 +14
==========================================
+ Hits 25353 25369 +16
+ Misses 8039 8037 -2
Partials 1180 1180
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 👏
It might be worth it to cache the result of the ConvertStaticToSemaType
in the values to avoid converting the static types to sema types each time. Maybe best to do this in a follow-up PR
Co-authored-by: Bastian Müller <bastian@axiomzen.co>
For function types, it shouldn't be too much of an overhead, since it only creates a thin wrapper. But definitely, we could cache these, and also cache parameter types, return types, etc in the |
Closes #1136
master
branchFiles changed
in the Github PR explorer