Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit error line lengths #1165

Merged
merged 2 commits into from Oct 6, 2021
Merged

Limit error line lengths #1165

merged 2 commits into from Oct 6, 2021

Conversation

turbolent
Copy link
Member

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent self-assigned this Oct 6, 2021
ramtinms
ramtinms reviewed Oct 6, 2021
View reviewed changes
runtime/pretty/print.go Outdated
@@ -52,6 +52,7 @@ func colorizeMeta(meta string) string {
const errorPrefix = "error"
const excerptArrow = "--> "
const excerptDots = "... "
const maxLineLength = 140
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

140 might be small something like 500 or larger I think makes more sense

SupunS
SupunS approved these changes Oct 6, 2021
View reviewed changes
Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@turbolent turbolent merged commit 5f28df0 into master Oct 6, 2021
@turbolent turbolent deleted the bastian/limit-error-printer-line-length branch October 6, 2021 21:44
@turbolent turbolent mentioned this pull request Oct 6, 2021
Closed
@turbolent turbolent restored the bastian/limit-error-printer-line-length branch October 6, 2021 21:45
@turbolent turbolent deleted the bastian/limit-error-printer-line-length branch March 1, 2022 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramtinms ramtinms ramtinms left review comments

@SupunS SupunS SupunS approved these changes

Assignees

@turbolent turbolent

Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@turbolent @ramtinms @SupunS