Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider halting when determining definite invalidation #1411

Merged
merged 3 commits into from Feb 11, 2022

Conversation

turbolent
Copy link
Member

Port of dapperlabs/cadence-internal#58

Description

When determining if a resource was definitely invalidated, also take into account the halting of the program.
This was previously already supported, but due to a bug (!), which was fixed in #1332.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

Codecov Report

Merging #1411 (cedc067) into v0.21 (f096b95) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            v0.21    #1411   +/-   ##
=======================================
  Coverage   75.72%   75.73%           
=======================================
  Files         273      273           
  Lines       36191    36200    +9     
=======================================
+ Hits        27406    27415    +9     
  Misses       7545     7545           
  Partials     1240     1240           
Flag Coverage Δ
unittests 75.73% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
runtime/sema/check_function.go 99.56% <100.00%> (+<0.01%) ⬆️
runtime/sema/check_invocation_expression.go 98.18% <100.00%> (+<0.01%) ⬆️
runtime/sema/resources.go 84.88% <100.00%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f096b95...cedc067. Read the comment docs.

@turbolent turbolent merged commit a16b82e into v0.21 Feb 11, 2022
@turbolent turbolent deleted the bastian/fix-halting-resource-invalidation branch February 11, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants