add memory kind last

[dsainati1]

Adds a new memory kind MemoryKindLast that should serve as an upper limit on memory kind values, allowing us to range over the minimum and maximum memory kinds.

---

• Targeted PR against master branch
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work
• Code follows the standards mentioned here
• Updated relevant documentation
• Re-reviewed Files changed in the Github PR explorer
• Added appropriate labels

[github-actions]

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/memory-metering commit b8efa6a
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Results

	old.txt	new.txt
	time/op		delta
RuntimeFungibleTokenTransfer-2	1.29ms ±24%	1.16ms ±31%	~	(p=0.710 n=7+7)
RuntimeResourceDictionaryValues-2	14.4ms ± 2%	14.4ms ± 2%	~	(p=0.902 n=7+7)
ParseDeploy/byte_array-2	21.2ms ± 7%	21.0ms ± 3%	~	(p=1.000 n=7+7)
ParseDeploy/decode_hex-2	1.16ms ± 1%	1.16ms ± 1%	~	(p=1.000 n=6+7)
ParseInfix-2	8.58µs ± 1%	8.84µs ± 7%	~	(p=0.101 n=6+7)
ParseFungibleToken/Without_memory_metering-2	187µs ± 1%	193µs ± 8%	~	(p=0.731 n=6+7)
ParseFungibleToken/With_memory_metering-2	201µs ± 1%	200µs ± 1%	~	(p=0.534 n=7+6)
ParseArray-2	13.0ms ± 4%	13.1ms ± 4%	~	(p=0.818 n=6+6)
QualifiedIdentifierCreation/One_level-2	2.68ns ± 0%	2.68ns ± 0%	~	(p=0.678 n=7+7)
QualifiedIdentifierCreation/Three_levels-2	137ns ± 1%	138ns ± 1%	~	(p=0.226 n=6+7)
ContractInterfaceFungibleToken-2	39.3µs ± 2%	40.5µs ±10%	~	(p=0.620 n=7+7)
CheckContractInterfaceFungibleTokenConformance-2	131µs ± 1%	131µs ± 1%	~	(p=1.000 n=7+6)
InterpretRecursionFib-2	2.85ms ± 3%	2.84ms ± 1%	~	(p=0.710 n=7+7)
NewInterpreter/new_interpreter-2	1.13µs ± 0%	1.12µs ± 1%	~	(p=0.385 n=5+6)
NewInterpreter/new_sub-interpreter-2	2.27µs ± 1%	2.27µs ± 1%	~	(p=0.763 n=7+6)
	alloc/op		delta
RuntimeFungibleTokenTransfer-2	274kB ± 0%	274kB ± 0%	~	(p=0.874 n=7+7)
RuntimeResourceDictionaryValues-2	4.05MB ± 0%	4.05MB ± 0%	~	(p=0.234 n=7+6)
ParseFungibleToken/Without_memory_metering-2	199kB ± 0%	199kB ± 0%	~	(all equal)
ParseFungibleToken/With_memory_metering-2	199kB ± 0%	199kB ± 0%	~	(p=0.538 n=6+7)
QualifiedIdentifierCreation/One_level-2	0.00B	0.00B	~	(all equal)
QualifiedIdentifierCreation/Three_levels-2	64.0B ± 0%	64.0B ± 0%	~	(all equal)
ContractInterfaceFungibleToken-2	26.6kB ± 0%	26.6kB ± 0%	~	(p=1.000 n=7+7)
CheckContractInterfaceFungibleTokenConformance-2	66.2kB ± 0%	66.2kB ± 0%	~	(all equal)
InterpretRecursionFib-2	1.26MB ± 0%	1.26MB ± 0%	~	(all equal)
NewInterpreter/new_interpreter-2	848B ± 0%	848B ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-2	1.36kB ± 0%	1.36kB ± 0%	~	(all equal)
	allocs/op		delta
RuntimeFungibleTokenTransfer-2	4.54k ± 0%	4.54k ± 0%	~	(p=0.592 n=7+7)
RuntimeResourceDictionaryValues-2	102k ± 0%	102k ± 0%	~	(p=0.277 n=7+6)
ParseFungibleToken/Without_memory_metering-2	1.07k ± 0%	1.07k ± 0%	~	(all equal)
ParseFungibleToken/With_memory_metering-2	1.07k ± 0%	1.07k ± 0%	~	(all equal)
QualifiedIdentifierCreation/One_level-2	0.00	0.00	~	(all equal)
QualifiedIdentifierCreation/Three_levels-2	2.00 ± 0%	2.00 ± 0%	~	(all equal)
ContractInterfaceFungibleToken-2	458 ± 0%	458 ± 0%	~	(all equal)
CheckContractInterfaceFungibleTokenConformance-2	1.07k ± 0%	1.07k ± 0%	~	(all equal)
InterpretRecursionFib-2	26.2k ± 0%	26.2k ± 0%	~	(all equal)
NewInterpreter/new_interpreter-2	13.0 ± 0%	13.0 ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-2	41.0 ± 0%	41.0 ± 0%	~	(all equal)

[codecov-commenter]

Codecov Report

Merging #1560 (2145b20) into feature/memory-metering (b8efa6a) will increase coverage by 0.00%.
The diff coverage is n/a.

@@                   Coverage Diff                    @@
##           feature/memory-metering    #1560   +/-   ##
========================================================
  Coverage                    76.36%   76.36%           
========================================================
  Files                          293      293           
  Lines                        58780    58780           
========================================================
+ Hits                         44885    44888    +3     
+ Misses                       12319    12318    -1     
+ Partials                      1576     1574    -2     

Flag	Coverage Δ
unittests	76.36% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
runtime/common/memorykind_string.go	0.00% <ø> (ø)
runtime/sema/simple_type.go	92.30% <0.00%> (-3.85%)	⬇️
runtime/sema/type.go	88.88% <0.00%> (+0.07%)	⬆️
runtime/sema/checker.go	89.65% <0.00%> (+0.11%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8efa6a...2145b20. Read the comment docs.