Take argument labels into account when declaring members for nested declarations #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1717 +/- ##
==========================================
- Coverage 77.00% 76.99% -0.02%
==========================================
Files 292 292
Lines 61187 61212 +25
==========================================
+ Hits 47117 47130 +13
- Misses 12459 12469 +10
- Partials 1611 1613 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 56d6da0 Results
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
dsainati1
approved these changes
Jun 13, 2022
robert-e-davidson3
approved these changes
Jun 13, 2022
turbolent
added
the
Language Breaking Change
SupunS
approved these changes
Jun 13, 2022
bors bot
added a commit
to onflow/flow-go
that referenced
this pull request
Jun 21, 2022
2653: Fix Cadence code r=turbolent a=turbolent In github.com/onflow/cadence#1717, the check of argument labels for nested constructors was fixed. Fix the previously accepted code, which is now rejected: - Update to the fixed core contracts - Add the missing argument label Co-authored-by: Bastian Müller <bastian@axiomzen.co>
bors bot
added a commit
to onflow/flow-go
that referenced
this pull request
Jun 23, 2022
2653: Fix Cadence code r=turbolent a=turbolent In github.com/onflow/cadence#1717, the check of argument labels for nested constructors was fixed. Fix the previously accepted code, which is now rejected: - Update to the fixed core contracts - Add the missing argument label Co-authored-by: Bastian Müller <bastian@axiomzen.co>
bors bot
added a commit
to onflow/flow-go
that referenced
this pull request
Jun 28, 2022
2653: Fix Cadence code r=turbolent a=turbolent In github.com/onflow/cadence#1717, the check of argument labels for nested constructors was fixed. Fix the previously accepted code, which is now rejected: - Update to the fixed core contracts - Add the missing argument label Co-authored-by: Bastian Müller <bastian@axiomzen.co> Co-authored-by: Daniel Sainati <sainatidaniel@gmail.com>
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When declaring the members for nested declarations, e.g. a composite declaration inside a contract, also take the argument labels of the nested declaration into account.
This was reported by @justjoolz, who also provided a great reproduction in https://github.com/justjoolz/struct-test 🙏
masterbranchFiles changedin the Github PR explorer